Skip to content

Exercise statement in pp_ctl.c: S_unwind_loop() #23954

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: blead
Choose a base branch
from
+28 −1
Open

Exercise statement in pp_ctl.c: S_unwind_loop() #23954

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions pp_ctl.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2886,6 +2886,8 @@ PP(pp_return)
if(CxTYPE(&cxstack[i]) == CXt_DEFER)
/* diag_listed_as: Can't "%s" out of a "defer" block */
/* diag_listed_as: Can't "%s" out of a "finally" block */
/* GH 23948: probably not reachable from test suite, but
* possibly from XS code; retain */
croak("Can't \"%s\" out of a \"%s\" block",
"return", S_defer_blockname(&cxstack[i]));
}
Expand Down
27 changes: 26 additions & 1 deletion t/op/defer.t
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ BEGIN {
set_up_inc('../lib');
}

plan 29;
plan 32;

use feature 'defer';
no warnings 'experimental::defer';
Expand Down Expand Up @@ -300,3 +300,28 @@ no warnings 'experimental::defer';

is($ok, "ok", 'eval{die} inside defer does not stop runloop');
}

# [GH #23948]
{
use warnings;
no warnings 'experimental';

my @warnings;
local $SIG{__WARN__} = sub { push @warnings, "@_" };

my $err = '';
for (1) {
defer {
eval 'last'; $err = $@; chomp $err;
}
}
is(scalar @warnings, 1, "Got exactly one warning");
like($warnings[0],
qr/Exiting eval via last at/,
"Got expected warning: exiting eval via last");
like(
$err,
qr/Can't "last" out of a "defer" block at \(eval \d+\) line 1\./,
"Got expected exception: last out of defer block");
}

Loading