Regression test fix option 1: Create fresh and not cloned environment to avoid cache issues#2942
Merged
JacksonBurns merged 1 commit intoReactionMechanismGenerator:mainfrom May 6, 2026
Conversation
Regression tests are broken because one package is messed up in the cache. This sacrifices a bit of extra time to build a clean environment but is more robust because problematic cached packages are less likely to cause problems in the future
JacksonBurns
approved these changes
May 6, 2026
Contributor
JacksonBurns
left a comment
JacksonBurns
left a comment
There was a problem hiding this comment.
Thanks for the quick fix. I agree that this option is better. Since this only crops up on github, it makes sense to me that we would fix it on the github side, rather than the environment file side
JacksonBurns
approved these changes
May 6, 2026
Contributor
JacksonBurns
left a comment
JacksonBurns
left a comment
There was a problem hiding this comment.
Thanks for the quick fix. I agree that this option is better. Since this only crops up on github, it makes sense to me that we would fix it on the github side, rather than the environment file side
Contributor
|
@sevyharris I think this may have crashed because of things unrelated to this PR. Can you confirm, and then I can force merge? |
Contributor
Author
|
Yeah, it's definitely running the regression tests now, so it's a step in the right direction. I think it's good to merge. |
JacksonBurns
merged commit edd0b57
into
ReactionMechanismGenerator:main
12 of 14 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation or Problem
Regression tests are broken because the x264 package is messed up in the cache. ffmpeg uses it. This sacrifices a bit of extra time to build a clean environment but is more robust because problematic cached packages are less likely to cause problems in the future.
Description of Changes
This changes the CI yaml file so that it creates a clean RMG environment for regression tests instead of cloning the existing rmg_env.
Testing
We'll see if this fixes the regression tests. (or at least gets them to run to completion)
We can compare how much time it adds on versus option 2. It seems creating a fresh environment is more robust than cloning, but is also a bit slower. I think we should probably go with this option unless it's about 5+ minutes slower.