Regression test fix option 2: Avoid package version that's breaking the regression test build#2943
Closed
sevyharris wants to merge 2 commits intoReactionMechanismGenerator:mainfrom
Closed
Conversation
Contributor
|
Closed in favor of: #2942 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation or Problem
Regression tests are broken because the x264 package is messed up in the cache. ffmpeg uses it.
Description of Changes
This fix explicitly forbids the offending package in the environment yaml. It's probably more of a bandaid than option 1: #2942 but allows us to keep cloning the rmg_env, and may be faster.
Testing
We'll see if this fixes the regression tests. (or at least gets them to run to completion)
Reviewer Tips
We'll see how much faster this is than option 1. My personal opinion is that if the speedup is more than about 5 minutes, we go with this fix. Otherwise, we should go with option 1.
Yeah, my first attempt at this failed because there are probably a ton of versions of x264 that don't work and we'll make things less flexible by pinning a specific version of x264. I don't think we should merge this, but I'll see if I can get a working version just for the time comparison.