-
Notifications
You must be signed in to change notification settings - Fork 26
e2e tests gang scheduling #242
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
e2e tests gang scheduling #242
Conversation
b0f7495 to
6ca3861
Compare
shayasoolin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I reviewed the infra code (shared_cluster.go and setup.go) changes, and the first new test in gang_scheduling_test.go.
I stopped there since my main comment is that I strongly suggest to invest time on having as many utility test functions as possible, and then reuse them for the test cases themselves.
We'll not just gain reusability and make it easier to maintain, but the test cases themselves will get much clearer as they will show as high-level function calls that look ideally as the comment above the test case: a list of steps.
Since this requires a non-trivial refactoring, I prefer to review the test logic itself after it's done. Thanks!
94db608 to
dfc20b3
Compare
|
Thanks @shayasoolin. I abstracted as much as I could into utility functions. PTAL. |
f2cb7cc to
f57f415
Compare
|
@shayasoolin @sanjaychatterjee updated to incorporate last suggestions. PTAL. |
ac591b6 to
52e7b92
Compare
julienmancuso
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2 nits, otherwise lgtm. Great job
4c39c79
Signed-off-by: Geoff Flarity <[email protected]>
Signed-off-by: Geoff Flarity <[email protected]>
Signed-off-by: Geoff Flarity <[email protected]>
Signed-off-by: Geoff Flarity <[email protected]>
Signed-off-by: Geoff Flarity <[email protected]>
Signed-off-by: Geoff Flarity <[email protected]>
Signed-off-by: Geoff Flarity <[email protected]>
Signed-off-by: Geoff Flarity <[email protected]>
Signed-off-by: Geoff Flarity <[email protected]>
Signed-off-by: Geoff Flarity <[email protected]>
Signed-off-by: Geoff Flarity <[email protected]>
Signed-off-by: Geoff Flarity <[email protected]>
Signed-off-by: Geoff Flarity <[email protected]>
Signed-off-by: Geoff Flarity <[email protected]>
Signed-off-by: Geoff Flarity <[email protected]>
049b9a6 to
4cf27c8
Compare
What type of PR is this?
Tests for gang scheduling as per the 'Grove Multi-Node QA Test Plan'.
What this PR does / why we need it:
Implements e2e tests for gang scheduling test scheduling.
Which issue(s) this PR fixes:
Special notes for your reviewer:
Does this PR introduce a API change?
Additional documentation e.g., enhancement proposals, usage docs, etc.: