feat(platform): expose state/reason/metadata filters in Run.results()#629
feat(platform): expose state/reason/metadata filters in Run.results()#629olivermeyer wants to merge 2 commits intomainfrom
Conversation
b3040cf to
001d65e
Compare
Codecov Report✅ All modified and coverable lines are covered by tests.
|
18c350f to
73a2254
Compare
akunft
left a comment
There was a problem hiding this comment.
- src/aignostics/platform/CLAUDE.md:812: is missing the new args
I think not testing pagination in the tests for this filter is fine.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
dfd959e to
d8e84ff
Compare
|
PR #629 Review Summary✅ PASS - Ready to merge All Critical Checks Pass:
Excellent Implementation:
Note on Test Timeouts: See full review details at: /tmp/pr_review.md Verdict: ✅ claude:review:passed |



Why?
Implements PYSDK-128 (originating ticket PAPI-4961).
GET /v1/runs/{run_id}/itemsalready acceptsstate,termination_reason, andcustom_metadata(JSONPath) filters, butRun.results()does not surface them — so callers that need filtered results fetch every item and filter client-side, wasting bandwidth and memory on large runs.How?
Adds three keyword-only parameters (
state,termination_reason,custom_metadata) toRun.results()and forwards them to the underlying generatedlist_run_items_v1_runs_run_id_items_getcall only when notNone, matching the existingitem_ids/external_idspattern. No codegen regeneration is needed; updatesspecifications/SPEC_PLATFORM_SERVICE.mdand adds five unit tests covering each filter individually, all three combined, and the no-filter omission case.I'm also removing the
--no-buildflags fromuv synccommands the Dockerfile to avoid failures.