Build, Core: Let RevAPI compare against 1.9.0 / Fix API breakage around StorageCredential #12930
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nastra
force-pushed
the
fix-api-breakage
branch
from
17ecab0 to
09e3b5f
Compare
nastra
commented
Apr 29, 2025
| static StorageCredential create(String prefix, Map<String, String> config) { | ||
| return ImmutableStorageCredential.builder() | ||
| .prefix(prefix) | ||
| .config(SerializableMap.copyOf(config)) |
Contributor
Author
There was a problem hiding this comment.
a SerializableMap will be created internally by the builder
danielcweeks
reviewed
May 5, 2025
core/src/main/java/org/apache/iceberg/io/ImmutableStorageCredential.java
Outdated
Show resolved
Hide resolved
danielcweeks
reviewed
May 5, 2025
core/src/main/java/org/apache/iceberg/io/ImmutableStorageCredential.java
Outdated
Show resolved
Hide resolved
danielcweeks
reviewed
May 5, 2025
core/src/main/java/org/apache/iceberg/io/ImmutableStorageCredential.java
Outdated
Show resolved
Hide resolved
danielcweeks
reviewed
May 5, 2025
core/src/main/java/org/apache/iceberg/io/ImmutableStorageCredential.java
Outdated
Show resolved
Hide resolved
danielcweeks
reviewed
May 5, 2025
core/src/main/java/org/apache/iceberg/io/ImmutableStorageCredential.java
Outdated
Show resolved
Hide resolved
…nd StorageCredential
devendra-nr
pushed a commit
to devendra-nr/iceberg
that referenced
this pull request
Dec 8, 2025
…nd StorageCredential (apache#12930)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#12882 went in right in between voting on 1.9.0 happened, which means that the API breakage wasn't detected as a breakage when it was merged. After upgrading RevAPI to compare against 1.9.0, the API breakage around Map -> SerializableMap was flagged.
The underlying issue is that Immutables will always create an unmodifiable Map (which isn't configurable and is generally what you want) when the API definition is
Map, which Kryo can't deal with, since Kryo adds back elements to the collection after deserialization. There is some hope that Kryo will eventually be able to deal with unmodifiable collections without having to use a separate kryo-serializers lib (EsotericSoftware/kryo#1154) but we're not there yet and maybe the better option would have been to not makeStorageCredentialuse Immutables in the first place due to Kryo.This PR adds the generated
ImmutableStorageCredentialclass to the codebase and creates aSerializableMapinstead of an unmodifiable one in order to work with Kryo and also to avoid the API breakage