This repository was archived by the owner on Nov 3, 2025. It is now read-only.
[issue-547] Knative Broker is required even if is not defined in SonataFlow or SonataFlowPlatform #553
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jianrongzhang89
changed the title
Member
ricardozanini
left a comment
ricardozanini
left a comment
There was a problem hiding this comment.
It seems pretty straightforward. Can you modify or add an e2e that validates it?
…d in the SonataFlow or SonataFlowPlatform CRs
jianrongzhang89
force-pushed
the
broker-optional
branch
from
4b7b2ff to
5a514f5
Compare
| Entry("without services configured", test.GetPathFromE2EDirectory("platform", "noservices"), metadata.GitOpsProfile.String(), ephemeral, false), | ||
| Entry("with services configured", test.GetPathFromE2EDirectory("platform", "services"), metadata.GitOpsProfile.String(), "ephemeral-with-workflow", true), | ||
| Entry("with services configured and platform broker", test.GetPathFromE2EDirectory("platform", "services"), metadata.GitOpsProfile.String(), "ephemeral-with-workflow", true), | ||
| Entry("with services configured and no broker", test.GetPathFromE2EDirectory("platform", "services"), metadata.GitOpsProfile.String(), "ephemeral-with-workflow-no-broker", true), |
Member
There was a problem hiding this comment.
Since this test does not have a SonataFlowClusterPlatform, I think the e2e label might be incorrect.
ricardozanini
approved these changes
Oct 17, 2024
Member
ricardozanini
left a comment
ricardozanini
left a comment
There was a problem hiding this comment.
Please disregard my comment. The new test uses a clustered platform.
Member
|
@wmedvede @jakubschwan can you please verify it? |
wmedvede
approved these changes
Oct 31, 2024
rgdoliveira
pushed a commit
to rgdoliveira/kogito-serverless-operator
that referenced
this pull request
Nov 6, 2024
…d in the SonataFlow or SonataFlowPlatform CRs (apache#553)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the following when Knative is installed:
Motivation for the change:
This is for backward compatibility with the latest operator release and usability. If will be up to the user to decide whether a broker should be configured for a workflow.
Checklist
Fix #547