Skip to content

Conversation

@xuzifu666
Copy link
Member

@xuzifu666 xuzifu666 commented Dec 1, 2025

What this PR does:

Which issue(s) this PR fixes:

Fixes #1008

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


@codecov-commenter
Copy link

codecov-commenter commented Dec 1, 2025

Codecov Report

❌ Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 61.64%. Comparing base (afb8650) to head (f3ffd85).

Files with missing lines Patch % Lines
pkg/datasource/sql/xa_resource_manager.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1011      +/-   ##
==========================================
- Coverage   61.65%   61.64%   -0.01%     
==========================================
  Files         213      213              
  Lines       13054    13056       +2     
==========================================
  Hits         8049     8049              
- Misses       4481     4483       +2     
  Partials      524      524              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@xuzifu666 xuzifu666 changed the title Connections leaks in database connections Connections leaks in resource manager Dec 2, 2025
Copy link
Contributor

@0x-infinity 0x-infinity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@0x-infinity 0x-infinity merged commit 6437e52 into apache:master Dec 2, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Connections leaks in resource manager

3 participants