Skip to content

fix: The navItems are not clickable with vimium (accessibility) - updated #578

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: The navItems are not clickable with vimium (accessibility) - updated #578

wants to merge 1 commit into from

Conversation

@michaelfresco
Copy link

@michaelfresco michaelfresco commented Nov 7, 2024

Background

  • I first tried the checkbox approach, this works fine but it is not semantically correct
  • Here we drop the div, add some css (thank you gaurav5430!!)

See also:

@michaelfresco
fix: The navItems are not clickable with vimium (accessibility) (#12813)
9f1f121 
- change: drop div + change css

Signed-off-by: Michael Fresco <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@michaelfresco