Solving Error Number #43815 #44408
Solving Error Number #43815 #44408
Conversation
DilshadNaleem
requested review from
MaryamZi,
gimantha,
hasithaa,
keizer619,
sameerajayasoma and
warunalakshitha
as code owners
|
The PR title and commit messages do not follow the best practices we commonly use. Please follow Contribution Guidelines. Also, please check other closed PRs for a reference. |
|
When fixing an issue, use |
| 'https://raw.githubusercontent.com/wso2/code-quality-tools/v1.4/checkstyle/jdk-14/checkstyle.xml', | ||
| 'https://raw.githubusercontent.com/wso2/code-quality-tools/v1.4/checkstyle/jdk-14/suppressions.xml' |
There was a problem hiding this comment.
Why are we downgrading the JDK version here?
There was a problem hiding this comment.
Please use the appropriate JDK version to build the source code. See Build Ballerina from source.
| // The member represents a special error for unhandled exceptions from the | ||
| // compiler | ||
| BAD_SAD_FROM_COMPILER("BCE9999", "bad.sad.from.compiler"), | ||
|
|
||
| UNDEFINED_MODULE("BCE2000", "undefined.module"), | ||
| CYCLIC_MODULE_IMPORTS_DETECTED("BCE2001", "cyclic.module.imports.detected"), | ||
| UNUSED_MODULE_PREFIX("BCE2002", "unused.module.prefix"), | ||
| MODULE_NOT_FOUND("BCE2003", "module.not.found"), | ||
| REDECLARED_IMPORT_MODULE("BCE2004", "redeclared.import.module"), | ||
| INVALID_MODULE_DECLARATION("BCE2005", "invalid.module.declaration"), | ||
| MISSING_MODULE_DECLARATION("BCE2006", "missing.module.declaration"), | ||
| UNEXPECTED_MODULE_DECLARATION("BCE2007", "unexpected.module.declaration"), | ||
| REDECLARED_SYMBOL("BCE2008", "redeclared.symbol"), | ||
| REDECLARED_BUILTIN_SYMBOL("BCE2009", "redeclared.builtin.symbol"), | ||
| UNDEFINED_SYMBOL("BCE2010", "undefined.symbol"), | ||
| UNDEFINED_FUNCTION("BCE2011", "undefined.function"), | ||
| UNDEFINED_FUNCTION_IN_TYPE("BCE2012", "undefined.function.in.type"), | ||
| UNDEFINED_METHOD_IN_OBJECT("BCE2013", "undefined.method.in.object"), | ||
| UNDEFINED_FIELD_IN_RECORD("BCE2014", "undefined.field.in.record"), | ||
| UNDEFINED_CONNECTOR("BCE2015", "undefined.connector"), | ||
| INVALID_ERROR_REASON_TYPE("BCE2016", "invalid.error.reason.type"), | ||
| UNSUPPORTED_ERROR_REASON_CONST_MATCH( | ||
| "BCE2017", "error.match.over.const.reason.ref.not.supported"), | ||
| INVALID_ERROR_DETAIL_TYPE("BCE2018", "invalid.error.detail.type"), | ||
| ERROR_DETAIL_ARG_IS_NOT_NAMED_ARG("BCE2019", "error.detail.arg.not.named.arg"), | ||
| DIRECT_ERROR_CTOR_REASON_NOT_PROVIDED("BCE2020", "missing.error.reason"), | ||
| OBJECT_TYPE_NOT_ALLOWED("BCE2021", "object.type.not.allowed"), | ||
| OBJECT_TYPE_REQUIRED("BCE2022", "object.type.required"), | ||
| UNDEFINED_STRUCTURE_FIELD_WITH_TYPE("BCE2023", "undefined.field.in.structure.with.type"), | ||
| UNDEFINED_STRUCTURE_FIELD("BCE2024", "undefined.field.in.structure"), | ||
| TYPE_NOT_ALLOWED_WITH_NEW("BCE2025", "type.not.allowed.with.new"), | ||
| INVALID_INTERSECTION_TYPE("BCE2026", "invalid.intersection.type"), | ||
| UNSUPPORTED_TYPE_INTERSECTION("BCE2027", "unsupported.type.intersection"), |
There was a problem hiding this comment.
Unnecessary and wrong indentation. Please check other places.
| private static final CompilerContext.Key<ReachabilityAnalyzer> REACHABILITY_ANALYZER_KEY = | ||
| new CompilerContext.Key<>(); | ||
| private static final CompilerContext.Key<ReachabilityAnalyzer> REACHABILITY_ANALYZER_KEY | ||
| = new CompilerContext.Key<>(); |
There was a problem hiding this comment.
ok sir sorry now i will change all these changes because i tried to solve the test cases, to build the whole project. the jdk version i downgrade it because after 3.30 am on the pull request day server founded 404 not found if the link was attached to the google directly it said 404 then again within time so many requests so to make my project work my last option was to downgrade then pull the pr request sir. now i will delete this pr then again folk the repo do the changes then i will re apply the changes
| <<<<<<< HEAD | ||
| public void visit(BLangFunction funcNode, AnalyzerData data) { | ||
| resetFunction(data); | ||
| if (funcNode.flagSet.contains(Flag.NATIVE)) { | ||
| return; | ||
| } | ||
| if (funcNode.body != null) { | ||
| analyzeReachability(funcNode.body, data); | ||
| boolean isNeverReturn = types.isNeverTypeOrStructureTypeWithARequiredNeverMember | ||
| (funcNode.symbol.type.getReturnType()); | ||
| // If the return signature is nil-able, an implicit return will be added in Desugar. | ||
| // Hence, this only checks for non-nil-able return signatures and uncertain return in the body. | ||
| if (!funcNode.symbol.type.getReturnType().isNullable() && !isNeverReturn && | ||
| !data.hasFunctionTerminated) { | ||
| Location closeBracePos = getEndCharPos(funcNode.pos); | ||
|
|
||
| String invokableName; | ||
|
|
||
| if (funcNode.getKind() == NodeKind.RESOURCE_FUNC) { | ||
| invokableName = "resource function"; | ||
| } else { | ||
| invokableName = funcNode.getKind().toString().toLowerCase(); | ||
| ======= |
There was a problem hiding this comment.
It seems you have not resolved this conflict properly nor merged properly.
2 participants
Purpose
Approach
Samples
Remarks
Check List