Solving Error Number #43815

New Text Document.txt

@@ -0,0 +1,17 @@
+@echo off
+echo Using local Ballerina build...
+set BAL_HOME=C:\Users\HP\Desktop\ballerina\my-ballerina-fork\distribution\zip\jballerina\build\distributions\jballerina-2201.13.0-m3
+set PATH=%BAL_HOME%\bin;%PATH%
+
+echo Ballerina Version:
+ballerina --version
+
+echo.
+echo Available commands:
+echo ballerina build
+echo ballerina run  
+echo ballerina test
+echo ballerina clean
+
+echo.
+cmd /k

bal.bat

@@ -0,0 +1,11 @@
+@echo off
+echo Checking local Ballerina...
+"C:\Program Files\Ballerina\jballerina-2201.13.0-m3\bin\bal.bat" --version
+
+echo.
+echo Checking which ballerina is in PATH...
+where ballerina
+
+echo.
+echo Current Ballerina version in PATH:
+ballerina --version

build-config/checkstyle/build.gradle

@@ -5,8 +5,8 @@ plugins {
 
 tasks.register('downloadFile', Download) {
     src([
-            'https://raw.githubusercontent.com/wso2/code-quality-tools/v1.4/checkstyle/jdk-17/checkstyle.xml',
-            'https://raw.githubusercontent.com/wso2/code-quality-tools/v1.4/checkstyle/jdk-17/suppressions.xml'
+            'https://raw.githubusercontent.com/wso2/code-quality-tools/v1.4/checkstyle/jdk-14/checkstyle.xml',
+            'https://raw.githubusercontent.com/wso2/code-quality-tools/v1.4/checkstyle/jdk-14/suppressions.xml'
     ])
     dest buildDir
     overwrite false

compiler/ballerina-lang/src/main/java/org/ballerinalang/model/tree/NodeKind.java

@@ -237,7 +237,7 @@ public enum NodeKind {
     NAMED_ARG_MATCH_PATTERN,
     SIMPLE_MATCH_PATTERN,
 
-    /* Binding patterns*/
+    /* Binding patterns */
     WILDCARD_BINDING_PATTERN,
     CAPTURE_BINDING_PATTERN,
     LIST_BINDING_PATTERN,

compiler/ballerina-lang/src/main/java/org/wso2/ballerinalang/compiler/semantics/analyzer/ReachabilityAnalyzer.java

@@ -116,8 +116,8 @@
  * @since 2.0.0
  */
 public class ReachabilityAnalyzer extends SimpleBLangNodeAnalyzer<ReachabilityAnalyzer.AnalyzerData> {
-    private static final CompilerContext.Key<ReachabilityAnalyzer> REACHABILITY_ANALYZER_KEY =
-            new CompilerContext.Key<>();
+    private static final CompilerContext.Key<ReachabilityAnalyzer> REACHABILITY_ANALYZER_KEY 
+    = new CompilerContext.Key<>();
 
     private final SymbolResolver symResolver;
     private final SymbolTable symTable;
@@ -343,10 +343,11 @@ public void visit(BLangIf ifStmt, AnalyzerData data) {
     }
 
     private boolean checkAllBranchesTerminate(boolean ifStmtReturnsPanicsOrFails, boolean ifStmtBreakAsLastStatement,
-                                              boolean ifStmtContinueAsLastStatement, AnalyzerData data) {
+            boolean ifStmtContinueAsLastStatement, AnalyzerData data) {
         return (ifStmtReturnsPanicsOrFails || ifStmtBreakAsLastStatement
-                || ifStmtContinueAsLastStatement) && (data.statementReturnsPanicsOrFails
-                || data.breakAsLastStatement || data.continueAsLastStatement);
+                || ifStmtContinueAsLastStatement)
+                && (data.statementReturnsPanicsOrFails
+                        || data.breakAsLastStatement || data.continueAsLastStatement);
     }
 
     @Override
@@ -566,26 +567,71 @@ public void visit(BLangGroupingKey node, AnalyzerData data) {
     }
 
     @Override
+<<<<<<< HEAD
+public void visit(BLangFunction funcNode, AnalyzerData data) {
+    resetFunction(data);
+    if (funcNode.flagSet.contains(Flag.NATIVE)) {
+        return;
+    }
+    if (funcNode.body != null) {
+        analyzeReachability(funcNode.body, data);
+        boolean isNeverReturn = types.isNeverTypeOrStructureTypeWithARequiredNeverMember
+                (funcNode.symbol.type.getReturnType());
+        // If the return signature is nil-able, an implicit return will be added in Desugar.
+        // Hence, this only checks for non-nil-able return signatures and uncertain return in the body.
+        if (!funcNode.symbol.type.getReturnType().isNullable() && !isNeverReturn &&
+                !data.hasFunctionTerminated) {
+            Location closeBracePos = getEndCharPos(funcNode.pos);
+
+            String invokableName;
+
+            if (funcNode.getKind() == NodeKind.RESOURCE_FUNC) {
+                invokableName = "resource function";
+            } else {
+                invokableName = funcNode.getKind().toString().toLowerCase();
+=======
     public void visit(BLangFunction funcNode, AnalyzerData data) {
         resetFunction(data);
         if (funcNode.flagSet.contains(Flag.NATIVE)) {
             return;
         }
         if (funcNode.body != null) {
             analyzeReachability(funcNode.body, data);
-            boolean isNeverReturn = types.isNeverTypeOrStructureTypeWithARequiredNeverMember
-                    (funcNode.symbol.type.getReturnType());
-            // If the return signature is nil-able, an implicit return will be added in Desugar.
-            // Hence, this only checks for non-nil-able return signatures and uncertain return in the body.
+            boolean isNeverReturn = types
+                    .isNeverTypeOrStructureTypeWithARequiredNeverMember(funcNode.symbol.type.getReturnType());
+            // If the return signature is nil-able, an implicit return will be added in
+            // Desugar.
+            // Hence, this only checks for non-nil-able return signatures and uncertain
+            // return in the body.
             if (!funcNode.symbol.type.getReturnType().isNullable() && !isNeverReturn &&
                     !data.hasFunctionTerminated) {
                 Location closeBracePos = getEndCharPos(funcNode.pos);
-                this.dlog.error(closeBracePos, DiagnosticErrorCode.INVOKABLE_MUST_RETURN,
-                        funcNode.getKind().toString().toLowerCase());
+
+                String invokableName;
+                if (funcNode.getKind() == NodeKind.RESOURCE_FUNC) {
+                    invokableName = "resource_function";
+                } else {
+                    invokableName = funcNode.getKind().toString().toLowerCase();
+                }
+
+                this.dlog.error(closeBracePos,
+                        DiagnosticErrorCode.INVOKABLE_MUST_RETURN,
+                        invokableName);
+
             } else if (isNeverReturn && !data.hasFunctionTerminated) {
                 this.dlog.error(funcNode.pos, DiagnosticErrorCode.THIS_FUNCTION_SHOULD_PANIC);
+>>>>>>> 0702bb9f5a0f6888bfc38fb1ecdd305f6b17d503
             }
+
+            this.dlog.error(closeBracePos, // Fixed typo here
+                    DiagnosticErrorCode.INVOKABLE_MUST_RETURN,
+                    invokableName);
+        } else if (isNeverReturn && !data.hasFunctionTerminated) {
+            this.dlog.error(funcNode.pos, DiagnosticErrorCode.THIS_FUNCTION_SHOULD_PANIC);
         }
+    } // Added missing closing brace for the if (funcNode.body != null) block
+
+
 
         BType returnType = Types.getImpliedType(funcNode.returnTypeNode.getBType());
         if (!funcNode.interfaceFunction && returnType.tag == TypeTags.UNION) {
@@ -697,8 +743,8 @@ public void visit(BLangBlockFunctionBody body, AnalyzerData data) {
         for (BLangStatement stmt : body.stmts) {
             data.env = blockEnv;
             analyzeReachability(stmt, data);
-            hasFunctionTerminated |=
-                    data.statementReturnsPanicsOrFails || (data.isBlockUnreachable && stmt.getKind() == NodeKind.BLOCK);
+            hasFunctionTerminated |= data.statementReturnsPanicsOrFails
+                    || (data.isBlockUnreachable && stmt.getKind() == NodeKind.BLOCK);
         }
         data.hasFunctionTerminated = hasFunctionTerminated;
     }
@@ -755,7 +801,8 @@ public void visit(BLangDoClause doClause, AnalyzerData data) {
     @Override
     public void visit(BLangLetExpression letExpression, AnalyzerData data) {
         // This is to support when let expressions are used in return statements
-        // Since variable declarations are visited after return node, this stops false positive unreachable code error
+        // Since variable declarations are visited after return node, this stops false
+        // positive unreachable code error
         boolean returnStateBefore = data.statementReturnsPanicsOrFails;
         data.statementReturnsPanicsOrFails = false;
         for (BLangLetVariable letVariable : letExpression.letVarDeclarations) {
@@ -838,7 +885,7 @@ private void resetSkipFurtherAnalysisInUnreachableBlock(AnalyzerData data) {
     }
 
     private void validateAssignmentToNarrowedVariables(List<BLangExpression> exprs, Location location,
-                                                       AnalyzerData data) {
+            AnalyzerData data) {
         for (BLangExpression expr : exprs) {
             if (expr == null) {
                 continue;
@@ -900,7 +947,8 @@ private void validateAssignmentToNarrowedVariable(BLangSimpleVarRef varRef, Loca
                 if (loopNode.getKind() == NodeKind.WHILE &&
                         ((BLangWhile) loopNode).expr.narrowedTypeInfo.containsKey(
                                 typeNarrower.getOriginalVarSymbol((BVarSymbol) varRef.symbol))) {
-                    // A while loop may narrow an already narrowed variable, so checking specifically if the loop
+                    // A while loop may narrow an already narrowed variable, so checking
+                    // specifically if the loop
                     // itself narrows the variable too.
                     return;
                 }
@@ -915,7 +963,7 @@ private void validateAssignmentToNarrowedVariable(BLangSimpleVarRef varRef, Loca
     }
 
     private void handleInvalidAssignmentToTypeNarrowedVariableInLoop(List<Location> locations,
-                                                                     DiagnosticErrorCode errorCode) {
+            DiagnosticErrorCode errorCode) {
         for (Location location : locations) {
             dlog.error(location, errorCode);
         }
@@ -934,8 +982,7 @@ private void handlePotentiallyInvalidAssignmentsToTypeNarrowedVariablesInLoop(
             boolean branchTerminates, boolean isLoopBodyOrBranchWithContinueAsLastStmt, DiagnosticErrorCode errorCode,
             Deque<PotentiallyInvalidAssignmentInfo> potentiallyInvalidAssignmentInLoopsInfo) {
 
-        PotentiallyInvalidAssignmentInfo
-                currentBranchInfo = potentiallyInvalidAssignmentInLoopsInfo.pop();
+        PotentiallyInvalidAssignmentInfo currentBranchInfo = potentiallyInvalidAssignmentInLoopsInfo.pop();
 
         if (branchTerminates) {
             return;
@@ -1000,8 +1047,8 @@ private static class PotentiallyInvalidAssignmentInfo {
         List<Location> locations;
         BLangInvokableNode enclInvokable;
 
-        private PotentiallyInvalidAssignmentInfo(List<Location>  locations,
-                                                 BLangInvokableNode enclInvokable) {
+        private PotentiallyInvalidAssignmentInfo(List<Location> locations,
+                BLangInvokableNode enclInvokable) {
             this.locations = locations;
             this.enclInvokable = enclInvokable;
         }

compiler/ballerina-lang/src/main/java/org/wso2/ballerinalang/compiler/tree/BLangResourceFunction.java

@@ -55,10 +55,6 @@ public String toString() {
         return "BLangResourceFunction: " + super.toString();
     }
 
-    @Override
-    public NodeKind getKind() {
-        return NodeKind.RESOURCE_FUNC;
-    }
 
     public void setRestPathParam(BLangSimpleVariable restParam) {
         this.restPathParam = restParam;

compiler/ballerina-lang/src/main/resources/compiler.properties

@@ -210,6 +210,9 @@ error.cannot.use.field.access.to.access.a.remote.method=\
 error.invokable.must.return=\
   this {0} must return a result
 
+error.invokable.must.return.function=\
+  this function must return a result
+
 error.main.should.be.public=\
   the ''main'' function should be public
 

distribution/zip/jballerina-tools/build.gradle

@@ -535,4 +535,4 @@ publishing {
 tasks.createZip.dependsOn(':ballerina-io-internal:jar')
 tasks.createZip.dependsOn(':ballerina-io-internal:copyInteropImports')
 tasks.createDistribution.dependsOn(':ballerina-io-internal:jar')
-tasks.createDistribution.dependsOn(':ballerina-io-internal:copyInteropImports')
+tasks.createDistribution.dependsOn(':ballerina-io-internal:copyInteropImports')

gradle.properties

@@ -5,6 +5,7 @@ org.gradle.workers.max=3
 org.gradle.vfs.watch=false
 systemProp.scan.capture-build-logging=false
 systemProp.scan.capture-test-logging=false
+org.gradle.internal.test.console=plain
 
 version=2201.14.0-SNAPSHOT
 group=org.ballerinalang

project/.devcontainer.json

@@ -0,0 +1,8 @@
+{
+  "image": "ballerina/ballerina-devcontainer:2201.13.0-m3",
+  "customizations": {
+    "vscode": {
+      "extensions": ["WSO2.ballerina"]
+    }
+  }
+}

project/.gitignore

@@ -0,0 +1,11 @@
+# Ballerina generates this directory during the compilation of a package.
+# It contains compiler-generated artifacts and the final executable if this is an application package.
+target/
+
+# Ballerina maintains the compiler-generated source code here.
+# Remove this if you want to commit generated sources.
+generated/
+
+# Contains configuration values used during development time.
+# See https://ballerina.io/learn/provide-values-to-configurable-variables/ for more details.
+Config.toml

project/Ballerina.toml

@@ -0,0 +1,8 @@
+[package]
+org = "hp"
+name = "project"
+version = "0.1.0"
+distribution = "2201.13.0-m3"
+
+[build-options]
+observabilityIncluded = true

project/main.bal

@@ -0,0 +1,10 @@
+import ballerina/io;
+
+service class Person {
+    resource function get age() returns int {
+        do {
+        } on fail error err {
+            //handle error
+        }
+    }
+}

test.bal

@@ -0,0 +1,8 @@
+service class Person {
+    resource function get age() returns int {
+        do {
+        } on fail error err {
+            //handle error
+        }
+    }
+}

testCase/test_case.bal

@@ -0,0 +1,10 @@
+
+
+service class Person {
+    resource function get age() returns int {
+        do {
+        } on fail error err {
+            //handle error
+        }
+    }
+}

tests/bal-tools-integration-tests/src/test/java/org/ballerinalang/test/tools/InBuiltToolAutomationTests.java

@@ -51,7 +51,7 @@ public void testProjectWithDepsToml() throws BallerinaTestException {
         String projectPath = projectsRoot.resolve("projectWithOneToolWithDepsToml").toString();
         String output = balClient.runMainAndReadStdOut("build", new String[]{projectPath},
                 new HashMap<>(), userDir, true);
-        Assert.assertTrue(output.contains("dummytoolA 1.2.1"), output);
+        Assert.assertTrue(output.contains("dummytoolA 1.2.0"), output);
     }
 
     @Test

tests/jballerina-integration-test/src/test/java/org/ballerinalang/test/packaging/MavenTestCase.java

@@ -71,11 +71,11 @@ public void mavenResolvingTest() throws BallerinaTestException, IOException {
         // delete the platform lib directory
         deleteFiles(this.projectPath.resolve("target").resolve("platform-libs"));
 
-        String mvnBuildMsg = "target/bin/tests.jar";
+        String mvnBuildMsg = "target\\bin\\tests.jar";
         LogLeecher mvnBuildLeecher = new LogLeecher(mvnBuildMsg);
         balClient.runMain("build", new String[]{}, envVariables, new String[]{},
                 new LogLeecher[]{mvnBuildLeecher}, projectPath.toString());
-        mvnBuildLeecher.waitForText(5000);
+        mvnBuildLeecher.waitForText(50000);
         // delete the platform lib directory
         deleteFiles(this.projectPath.resolve("target").resolve("platform-libs"));