feat: Case-insensitive search for non-ASCII chat and contact names (#7477) #7548
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
link2xt
approved these changes
Dec 4, 2025
Collaborator
link2xt
left a comment
link2xt
left a comment
There was a problem hiding this comment.
Looks good, if it was tested on a real database with many chats and contacts then can be merged.
| { | ||
| let (id, name) = res?; | ||
| if let Some(name_normalized) = normalize_text(&name) { | ||
| stmt.execute((name_normalized, id))?; |
Collaborator
There was a problem hiding this comment.
Does this run successfully on a real database? I am not sure about stepping over SELECT statement from a table and updating the same table in the same loop. Should probably be fine as long as you don't modify the columns that affect SELECT result or its order, but have not found if it is guaranteed.
Collaborator
Author
There was a problem hiding this comment.
Yes, probably should always work as it just fills a new column, at least my db migrated successfully and the search works as expected
…7477) This makes `Contact::get_all()` and `Chatlist::try_load()` case-insensitive for non-ASCII chat and contact names as well. The same approach as in f6f4ccc "feat: Case-insensitive search for non-ASCII messages (#5052)" is used: `chats.name_normalized` and `contacts.name_normalized` colums are added which store lowercased/normalized names (for a contact, if the name is unset, it's a normalized authname). If a normalized name is the same as the chat/contact name, it's not stored to reduce the db size. A db migration is added for 10000 random chats and the same number of the most recently seen contacts, for users it will probably migrate all chats/contacts and for bots which may have more data it's not important.
iequidoo
force-pushed
the
iequidoo/case-insensitive-name-search
branch
from
a70c4d5 to
cd444d2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes
Contact::get_all()andChatlist::try_load()case-insensitive for non-ASCII chat and contact names as well. The same approach as in f6f4ccc "feat: Case-insensitive search for non-ASCII messages (#5052)" is used:chats.name_normalizedandcontacts.name_normalizedcolums are added which store lowercased/normalized names (for a contact, if the name is unset, it's a normalized authname). If a normalized name is the same as the chat/contact name, it's not stored to reduce the db size. A db migration is added for 10000 random chats and the same number of the most recently seen contacts, for users it will probably migrate all chats/contacts and for bots which may have more data it's not important.Fix #7477