blockchain: Early null revocation input check.#3684
Merged
davecgh merged 1 commit intodecred:masterfrom May 6, 2026
Merged
Conversation
dajohi
approved these changes
May 6, 2026
jrick
approved these changes
May 6, 2026
The early null output check for the ticket input of revocations was inadvertently removed when the automatic revocations agenda was introduced. This restores that check. Not doing the early check doesn't cause any real issue because later checks will fail on attempting to lookup a null output anyway, but it is always ideal to fail as early as possible to avoid additional unnecessary work.
davecgh
force-pushed
the
blockchain_early_nulloutpoint_check
branch
from
317f767 to
e0eaa8f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The early null output check for the ticket input of revocations was inadvertently removed when the automatic revocations agenda was introduced. This restores that check.
Not doing the early check doesn't cause any real issue because later checks will fail on attempting to lookup a null output anyway, but it is always ideal to fail as early as possible to avoid additional unnecessary work.