Skip to content

blockchain: Early null revocation input check. #3684

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
davecgh merged 1 commit into from
May 6, 2026
+9 −3
Merged

blockchain: Early null revocation input check. #3684

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions internal/blockchain/validate.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -434,7 +434,6 @@ func checkTransactionContext(tx *wire.MsgTx, params *chaincfg.Params, flags Agen
isCoinBase = standalone.IsCoinBaseTx(tx, isTreasuryEnabled)
}

// Take action on type.
switch {
case isVote:
// Check script length of stake base signature.
Expand All @@ -454,10 +453,10 @@ func checkTransactionContext(tx *wire.MsgTx, params *chaincfg.Params, flags Agen
return ruleError(ErrBadStakebaseScrVal, str)
}

// The ticket reference hash in an SSGen tx must not be null.
// The referenced ticket in a vote must not be null.
ticketHash := &tx.TxIn[1].PreviousOutPoint
if isNullOutpoint(ticketHash) {
str := "vote ticket input refers to previous output that is null"
const str = "vote ticket input refers to null previous output"
return ruleError(ErrBadTxInput, str)
}

Expand All @@ -472,6 +471,13 @@ func checkTransactionContext(tx *wire.MsgTx, params *chaincfg.Params, flags Agen
return ruleError(ErrInvalidRevocationTxVersion, str)
}

// The referenced ticket in a revocation must not be null.
ticketHash := &tx.TxIn[0].PreviousOutPoint
if isNullOutpoint(ticketHash) {
const str = "revocation ticket input refers to null previous output"
return ruleError(ErrBadTxInput, str)
}

case isCoinBase:
// The referenced outpoint must be null.
if !isNullOutpoint(&tx.TxIn[0].PreviousOutPoint) {
Expand Down