Conversation
us-east-1 detected |
wlcx
left a comment
There was a problem hiding this comment.
I know this is partially a draft PR, sorry if you already had any of these on your list!
- Looks like the migration needs "rebasing" onto the newest HEAD migration.
- My humble request would be for new code to have type annotations. Very happy to help if there's any mypy gnarliness.
- From a UX perspective I think we should state the markdown limitations (i.e. images disabled) in the form.
I'll leave the security considerations to someone with more experience in that area 😅
| <a href="{{ village.map_link }}">📍 Map</a> | ||
| {% endif %} | ||
|
|
||
| {# TODO: Can we show what's on at the village venues here? #} |
There was a problem hiding this comment.
I was going to say that I'm not sure whether there's a link between Venue and Village, but on closer look Venue has a village_id field :)
@SamLR is this planned to still be the case?
8b17a7b to
3ad70e8
Compare
df508ac to
911877f
Compare
|
This conflicted slightly with #1717 creating _village.scss and _villages.scss, and the DB migration needed updating. I've rebased and moved the branch to 1863-village-long-description. |
|
Replaced with #1935 |
|
Thanks for all your work on this @ashirley! |
There is still a lot to tidy up here but wanted to get some opinions sooner rather than later about iFrame layout options
Add a long_description field to villages. This is markdown from untrusted users and is rendered using nh3 and a sandboxed iFrame in order to limit the untrusted HTML.
There are 2 layout options for the iFrame:
The first uses javascript to resize the iFrame to prevent scrolling within the iFrame.
The second uses a static size for the iFrame which scrolls for long content.
The advantage of the second is that we can remove the allow-scripts privilege from the iFrame.
fixes #1816