Skip to content

Village long description#1863

Closed
ashirley wants to merge 14 commits intoemfcamp:mainfrom
ashirley:village-long-description
Closed

Village long description#1863
ashirley wants to merge 14 commits intoemfcamp:mainfrom
ashirley:village-long-description

Conversation

@ashirley
Copy link
Contributor

@ashirley ashirley commented Oct 20, 2025

There is still a lot to tidy up here but wanted to get some opinions sooner rather than later about iFrame layout options

Add a long_description field to villages. This is markdown from untrusted users and is rendered using nh3 and a sandboxed iFrame in order to limit the untrusted HTML.

There are 2 layout options for the iFrame:

The first uses javascript to resize the iFrame to prevent scrolling within the iFrame.

vivaldi_2gFsXcJgpn

The second uses a static size for the iFrame which scrolls for long content.

vivaldi_UirExic3aR

The advantage of the second is that we can remove the allow-scripts privilege from the iFrame.

fixes #1816

@ashirley ashirley mentioned this pull request Oct 20, 2025
@wlcx
Copy link
Member

wlcx commented Oct 20, 2025

unexpected status from HEAD request to https://registry-1.docker.io/v2/library/node/manifests/12-alpine: 500 Internal Server Error

us-east-1 detected

Copy link
Member

@wlcx wlcx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know this is partially a draft PR, sorry if you already had any of these on your list!

  • Looks like the migration needs "rebasing" onto the newest HEAD migration.
  • My humble request would be for new code to have type annotations. Very happy to help if there's any mypy gnarliness.
  • From a UX perspective I think we should state the markdown limitations (i.e. images disabled) in the form.

I'll leave the security considerations to someone with more experience in that area 😅

<a href="{{ village.map_link }}">📍&nbsp;Map</a>
{% endif %}

{# TODO: Can we show what's on at the village venues here? #}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was going to say that I'm not sure whether there's a link between Venue and Village, but on closer look Venue has a village_id field :)

@SamLR is this planned to still be the case?

@ashirley ashirley force-pushed the village-long-description branch 2 times, most recently from 8b17a7b to 3ad70e8 Compare December 9, 2025 22:46
@marksteward marksteward mentioned this pull request Jan 3, 2026
8 tasks
@ashirley ashirley force-pushed the village-long-description branch from df508ac to 911877f Compare January 26, 2026 21:24
@marksteward
Copy link
Member

marksteward commented Mar 22, 2026

This conflicted slightly with #1717 creating _village.scss and _villages.scss, and the DB migration needed updating. I've rebased and moved the branch to 1863-village-long-description.

@marksteward
Copy link
Member

Replaced with #1935

@marksteward
Copy link
Member

Thanks for all your work on this @ashirley!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Village details page

5 participants