Merged
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Check the height is numeric before using it, fix the margins and padding on the body, make the background transparent. There's still a flash of white when shortening a div which I can't pin down, but it doesn't seem to happen during normal use. A selection drag inside the iframe does nothing, and one from above doesn't apply until you reach the bottom of the iframe, but I don't think we can reasonably fix either.
marksteward
force-pushed
the
1863-village-long-description
branch
from
91ccaf0 to
2c750a3
Compare
Default to scrollbars for when JavaScript is unavailable, remove them if we reckon we can resize the content.
marksteward
force-pushed
the
1863-village-long-description
branch
from
2c750a3 to
7af0f0b
Compare
marksteward
force-pushed
the
1863-village-long-description
branch
from
efc0dc6 to
5732c5a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replacement for #1863. I've merged the two layouts, fixed padding/margins, and made the message handling safer.