[Adjsut][v2] PR from fork repo without using a build CI image to check by SZL741023 · Pull Request #6952 · flyteorg/flyte

SZL741023 · 2026-03-01T10:23:30Z

Tracking issue

Related to: (#6845)

Why are the changes needed?

In original work flow, if files gen.Dockerfile and build-ci-image.yml have been changed, the action for build ci image will be trigger. The action for check generation will be exercise after a new ci image is built.

If the PR from fork repo, the ci image should not be rebuild.

What changes were proposed in this pull request?

In file build-ci-image.yml add the condition to check the PR is from the same repo or fork repo.
If PR is from fork repo, build ci image will be skip.

In file check-generation.yml add the condition to check the PR is from the same repo or fork repo.
If PR is from fork repo, the action for check generation will be run in locally runner.
Extract the tool versions from gen.Dockerfile to ensure that the correct version information is used.

How was this patch tested?

Ensure the PR from fork repo will not trigger the action for build ci image, and check generation will be run in locally runner.

Labels

Please add one or more of the following labels to categorize your PR:

added: For new features.
changed: For changes in existing functionality.
deprecated: For soon-to-be-removed features.
removed: For features being removed.
fixed: For any bug fixed.
security: In case of vulnerabilities

This is important to improve the readability of release notes.

Setup process

Screenshots

Check all the applicable boxes

I updated the documentation accordingly.
All new and existing tests passed.
All commits are signed-off.

Related PRs

Docs link

main
- Flyte 2 WIP #6583
  - [Adjsut][v2] PR from fork repo without using a build CI image to check #6952 👈

flyteorg#6845) If PR from the fork repo, do not use the CI image to check. Adjust checking action to local runner. Signed-off-by: SZL741023 <shengzhe.lin@icloud.com>

.github/workflows/check-generate.yml

Refactor the check generation yaml file, separate the check method when the PR is from fork repo or not. Signed-off-by: SZL741023 <shengzhe.lin@icloud.com>

Signed-off-by: SZL741023 <shengzhe.lin@icloud.com>

…ing (flyteorg#6592) Signed-off-by: SZL741023 <shengzhe.lin@icloud.com>

Signed-off-by: SZL741023 <shengzhe.lin@icloud.com>

Signed-off-by: SZL741023 <48779231+SZL741023@users.noreply.github.com>

Signed-off-by: SZL741023 <shengzhe.lin@icloud.com>

…eneration (flyteorg#6986) * update Signed-off-by: M. Adil Fayyaz <62440954+AdilFayyaz@users.noreply.github.com> * tests Signed-off-by: M. Adil Fayyaz <62440954+AdilFayyaz@users.noreply.github.com> * fix Signed-off-by: M. Adil Fayyaz <62440954+AdilFayyaz@users.noreply.github.com> * remove lock file Signed-off-by: Kevin Su <pingsutw@apache.org> --------- Signed-off-by: M. Adil Fayyaz <62440954+AdilFayyaz@users.noreply.github.com> Signed-off-by: Kevin Su <pingsutw@apache.org> Co-authored-by: Kevin Su <pingsutw@apache.org>

Signed-off-by: Kevin Su <pingsutw@apache.org>

* add helm chart Signed-off-by: Alex Wu <c.alexwu@gmail.com> * add docker folder for running k3s cluster Signed-off-by: Alex Wu <c.alexwu@gmail.com> * delete queue state service add actions service Signed-off-by: Alex Wu <c.alexwu@gmail.com> * delete queue state service add actions service Signed-off-by: Alex Wu <c.alexwu@gmail.com> * patch k8s secret config Signed-off-by: Alex Wu <c.alexwu@gmail.com> * fix unimplement rpc issue Signed-off-by: Alex Wu <c.alexwu@gmail.com> * fix k8s dashboard conflict issue Signed-off-by: Alex Wu <c.alexwu@gmail.com> * add normalize path function to std lib Signed-off-by: Alex Wu <c.alexwu@gmail.com> * add sandbox-stop command and fix sandbox command name Signed-off-by: Alex Wu <c.alexwu@gmail.com> * remove cargo file in gen folder Signed-off-by: Alex Wu <c.alexwu@gmail.com> * fix doc flyte version Signed-off-by: Alex Wu <c.alexwu@gmail.com> * delete connector config in configmap Signed-off-by: Alex Wu <c.alexwu@gmail.com> * add sqlite config Signed-off-by: Alex Wu <c.alexwu@gmail.com> * delete service annotation config Signed-off-by: Alex Wu <c.alexwu@gmail.com> * fix ingress config Signed-off-by: Alex Wu <c.alexwu@gmail.com> * regen manifests Signed-off-by: Alex Wu <c.alexwu@gmail.com> * fix some docker script error Signed-off-by: Alex Wu <c.alexwu@gmail.com> * regenerate manifests Signed-off-by: Alex Wu <c.alexwu@gmail.com> * fix dicker image name Signed-off-by: Alex Wu <c.alexwu@gmail.com> * add kube folder to gitignore Signed-off-by: Alex Wu <c.alexwu@gmail.com> * remove test make script under sandbox bundle folder Signed-off-by: Alex Wu <c.alexwu@gmail.com> * fix test cases Signed-off-by: Alex Wu <c.alexwu@gmail.com> * delete cargo.lock Signed-off-by: Alex Wu <c.alexwu@gmail.com> * regenerate proto Signed-off-by: Alex Wu <c.alexwu@gmail.com> * fix gen diff check rule Signed-off-by: Alex Wu <c.alexwu@gmail.com> * fix gen check rule to exclude Cargo Signed-off-by: Alex Wu <c.alexwu@gmail.com> * delete complete-connector folder Signed-off-by: Alex Wu <c.alexwu@gmail.com> * fix sandbox cluster name Signed-off-by: Alex Wu <c.alexwu@gmail.com> --------- Signed-off-by: Alex Wu <c.alexwu@gmail.com>

* feat: add EventsService proto Signed-off-by: machichima <nary12321@gmail.com> * feat: add event background worker Signed-off-by: machichima <nary12321@gmail.com> * feat: add events service Signed-off-by: machichima <nary12321@gmail.com> * feat: add to main.go Signed-off-by: machichima <nary12321@gmail.com> * refactor: cleanup executor cmd main.go Signed-off-by: machichima <nary12321@gmail.com> * feat: call eventsClient.Record in executor when having update Signed-off-by: machichima <nary12321@gmail.com> * docs: update development guide Signed-off-by: machichima <nary12321@gmail.com> * feat: add scripts Signed-off-by: machichima <nary12321@gmail.com> * feat: events record use direct RPC req & remove background worker Signed-off-by: machichima <nary12321@gmail.com> * refactor: rename to events proxy service proto Signed-off-by: machichima <nary12321@gmail.com> * refactor: rename to events proxy service Signed-off-by: machichima <nary12321@gmail.com> * refactor: StateServiceURL to EventsServiceURL Signed-off-by: machichima <nary12321@gmail.com> * fix: raise error when fail to persist action event Signed-off-by: machichima <nary12321@gmail.com> * fix: remove redundant if condition Signed-off-by: machichima <nary12321@gmail.com> * fix: update status after persisted Signed-off-by: machichima <nary12321@gmail.com> * fix: remove unused code Signed-off-by: machichima <nary12321@gmail.com> * fix: bug + remove cluster command Signed-off-by: machichima <nary12321@gmail.com> --------- Signed-off-by: machichima <nary12321@gmail.com>

Signed-off-by: Kevin Su <pingsutw@apache.org>

Signed-off-by: machichima <nary12321@gmail.com>

Signed-off-by: Kevin Su <pingsutw@apache.org> Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>

* add: validation Signed-off-by: M. Adil Fayyaz <62440954+AdilFayyaz@users.noreply.github.com> * fix Signed-off-by: M. Adil Fayyaz <62440954+AdilFayyaz@users.noreply.github.com> * [V2] Add GitHub Actions workflow for Go unit tests (flyteorg#6999) Signed-off-by: Kevin Su <pingsutw@apache.org> * add: validation Signed-off-by: M. Adil Fayyaz <62440954+AdilFayyaz@users.noreply.github.com> * fix Signed-off-by: M. Adil Fayyaz <62440954+AdilFayyaz@users.noreply.github.com> * minor fix Signed-off-by: M. Adil Fayyaz <62440954+AdilFayyaz@users.noreply.github.com> * fix: tests Signed-off-by: M. Adil Fayyaz <62440954+AdilFayyaz@users.noreply.github.com> --------- Signed-off-by: M. Adil Fayyaz <62440954+AdilFayyaz@users.noreply.github.com> Signed-off-by: Kevin Su <pingsutw@apache.org> Co-authored-by: Kevin Su <pingsutw@apache.org>

* Notifications IDL Signed-off-by: Iaroslav Ciupin <iaroslav@union.ai>

* Fix Docker build for CGO-dependent sqlite3 package The build was failing because `go-sqlite3` requires CGO, but the Dockerfile used cross-compilation (`--platform=${BUILDPLATFORM}`) which disables CGO. Additionally, the .dockerignore negation pattern for `gen/go` was unreliable when the parent `gen/` directory was excluded. - Remove cross-compilation, enable CGO_ENABLED=1 for native build - Copy only gen/go instead of full gen directory - Replace .dockerignore negation with explicit subdirectory exclusions Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: Kevin Su <pingsutw@apache.org> * test Signed-off-by: Kevin Su <pingsutw@apache.org> --------- Signed-off-by: Kevin Su <pingsutw@apache.org> Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>

Signed-off-by: Iaroslav Ciupin <iaroslav@union.ai>

…ng the /config HTTP endpoint. Add pflags-generated config files and fix import paths to use non-versioned module. (flyteorg#7015) * Add DisableConfigEndpoint option to profutils Config to allow disabling the /config HTTP endpoint. Add pflags-generated config files and fix import paths to use non-versioned module. Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com> * fix imports Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com> * Fix tests Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com> * Fix config registration Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com> * Fix unit tests Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com> --------- Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com>

…org#7018)

* feat: simple state manager to store actions Signed-off-by: machichima <nary12321@gmail.com> * feat: run state manager record node tree Signed-off-by: machichima <nary12321@gmail.com> * fix: also include root action in ListActions Signed-off-by: machichima <nary12321@gmail.com> * fix: prevent error when create default project on startup Signed-off-by: machichima <nary12321@gmail.com> * feat: add watch_actions.sh test script Signed-off-by: machichima <nary12321@gmail.com> * fix: continue for nil enrichedAction for defense Signed-off-by: machichima <nary12321@gmail.com> * fix: raise error in CreateProject when already exists Signed-off-by: machichima <nary12321@gmail.com> --------- Signed-off-by: machichima <nary12321@gmail.com>

.github/workflows/check-generate.yml

…ehavior (flyteorg#7028) Signed-off-by: Katrina Rogan <katroganGH@gmail.com>

Signed-off-by: M. Adil Fayyaz <62440954+AdilFayyaz@users.noreply.github.com>

Signed-off-by: Kevin Su <pingsutw@apache.org>

…lyteorg#7031) * abort - add Signed-off-by: M. Adil Fayyaz <62440954+AdilFayyaz@users.noreply.github.com> * update Signed-off-by: M. Adil Fayyaz <62440954+AdilFayyaz@users.noreply.github.com> * update test Signed-off-by: M. Adil Fayyaz <62440954+AdilFayyaz@users.noreply.github.com> --------- Signed-off-by: M. Adil Fayyaz <62440954+AdilFayyaz@users.noreply.github.com>

…lyteorg#7033) * fix problems about missing charts and kubeconfig permission Signed-off-by: yuteng <a08h0283@gmail.com> * make dep_build including updating helm-repo and build charts Signed-off-by: yuteng <a08h0283@gmail.com> * deleted unused operator Signed-off-by: yuteng <a08h0283@gmail.com> --------- Signed-off-by: yuteng <a08h0283@gmail.com>

Signed-off-by: SZL741023 <shengzhe.lin@icloud.com>

…g#7025) * adjust notifications IDL to support notifications per phases * drop delivery config id & rule id * email idl adjustments Signed-off-by: Iaroslav Ciupin <iaroslav@union.ai>

To facilitate getting logs just for a single node, add an optional field to the ContainerSelector message. Signed-off-by: Eugene Yakubovich <eyakubovich@gmail.com>

Signed-off-by: Barry Wu <a0987818905@gmail.com>

Adjust check-generate workflow that will call other workflows and check other workflows will be failure or not Separate original check-generate workflow to check-generate-container.yml and rename to check-generate-container Add new workflow file check-generate-local.yml for the PR from fork repo Signed-off-by: SZL741023 <shengzhe.lin@icloud.com>

flyteorg#6845) If PR from the fork repo, do not use the CI image to check. Adjust checking action to local runner. Signed-off-by: SZL741023 <shengzhe.lin@icloud.com>

Refactor the check generation yaml file, separate the check method when the PR is from fork repo or not. Signed-off-by: SZL741023 <shengzhe.lin@icloud.com>

Signed-off-by: SZL741023 <shengzhe.lin@icloud.com>

…ing (flyteorg#6592) Signed-off-by: SZL741023 <shengzhe.lin@icloud.com>

Signed-off-by: SZL741023 <shengzhe.lin@icloud.com>

Adjust check-generate workflow that will call other workflows and check other workflows will be failure or not Separate original check-generate workflow to check-generate-container.yml and rename to check-generate-container Add new workflow file check-generate-local.yml for the PR from fork repo Signed-off-by: SZL741023 <shengzhe.lin@icloud.com>

… v2_git_workflow_dev Signed-off-by: SZL741023 <shengzhe.lin@icloud.com>

SZL741023 · 2026-03-18T16:01:27Z

Superseded by #7040

[Adjsut][v2] PR from fork repo without using a build CI image to check (

2a9b512

flyteorg#6845) If PR from the fork repo, do not use the CI image to check. Adjust checking action to local runner. Signed-off-by: SZL741023 <shengzhe.lin@icloud.com>

github-actions bot mentioned this pull request Feb 28, 2026

Flyte 2 WIP #6583

Draft

3 tasks

machichima requested changes Mar 7, 2026

View reviewed changes

.github/workflows/check-generate.yml Outdated Show resolved Hide resolved

.github/workflows/check-generate.yml Outdated Show resolved Hide resolved

.github/workflows/check-generate.yml Show resolved Hide resolved

SZL741023 and others added 15 commits March 8, 2026 22:05

[Refac][v2] PR from fork repo without using CI image

c4a6e4e

Refactor the check generation yaml file, separate the check method when the PR is from fork repo or not. Signed-off-by: SZL741023 <shengzhe.lin@icloud.com>

Update Cargo.lock

239c98c

Signed-off-by: SZL741023 <shengzhe.lin@icloud.com>

fix: correct the conditional statement should compare boolean not str…

605c879

…ing (flyteorg#6592) Signed-off-by: SZL741023 <shengzhe.lin@icloud.com>

fix: correct the conditional statement should compare boolean not str…

c93659a

…ing (flyteorg#6592) Signed-off-by: SZL741023 <shengzhe.lin@icloud.com>

chore: update generated files

2c08f60

Signed-off-by: SZL741023 <shengzhe.lin@icloud.com>

Merge branch 'v2' into v2_git_workflow_dev

69323c8

Signed-off-by: SZL741023 <48779231+SZL741023@users.noreply.github.com>

fix: update generated files

ce9a273

Signed-off-by: SZL741023 <shengzhe.lin@icloud.com>

fix: set explicit 5-minute timeout on TaskAction watch (flyteorg#6996)

000d9ac

Signed-off-by: Kevin Su <pingsutw@apache.org>

Add IdentityService (UserInfo) stub to runs service (flyteorg#6997)

cc948ba

Signed-off-by: Kevin Su <pingsutw@apache.org>

[V2] Add GitHub Actions workflow for Go unit tests (flyteorg#6999)

24da84f

Signed-off-by: Kevin Su <pingsutw@apache.org>

[V2] Add project service (flyteorg#7000)

285e6c1

Signed-off-by: machichima <nary12321@gmail.com>

[V2] Add TaskAction garbage collector for terminal CRDs (flyteorg#6994)

df8959c

Signed-off-by: Kevin Su <pingsutw@apache.org> Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>

pingsutw assigned SZL741023 and machichima Mar 11, 2026

pingsutw added the flyte2 label Mar 11, 2026

katrogan and others added 8 commits March 11, 2026 09:02

Add include_system_secrets to secrets apis (flyteorg#7007)

5d6477c

Notifications IDL (flyteorg#6946)

4f001cb

* Notifications IDL Signed-off-by: Iaroslav Ciupin <iaroslav@union.ai>

notification event type IDL (flyteorg#7021)

967627c

Signed-off-by: Iaroslav Ciupin <iaroslav@union.ai>

[Sandbox][RunService]Switch database from sqlite to postgresql (flyte…

2716120

…org#7018)

machichima reviewed Mar 13, 2026

View reviewed changes

.github/workflows/check-generate.yml Outdated Show resolved Hide resolved

machichima reviewed Mar 13, 2026

View reviewed changes

.github/workflows/check-generate.yml Outdated Show resolved Hide resolved

katrogan and others added 19 commits March 13, 2026 20:04

Add new role ROLE_TYPE_SYSTEM_PROVISIONED_ACCESS for default system b…

de03a84

…ehavior (flyteorg#7028) Signed-off-by: Katrina Rogan <katroganGH@gmail.com>

minio patch (flyteorg#7027)

9ffc84f

Signed-off-by: M. Adil Fayyaz <62440954+AdilFayyaz@users.noreply.github.com>

Add log links support to task template (flyteorg#7030)

1f91f85

Signed-off-by: Kevin Su <pingsutw@apache.org>

fix: fixed the variable type of checking docker image is modified or not

81689f8

Signed-off-by: SZL741023 <shengzhe.lin@icloud.com>

Adjust notifications IDL to support notifications per phases (flyteor…

f11aad3

…g#7025) * adjust notifications IDL to support notifications per phases * drop delivery config id & rule id * email idl adjustments Signed-off-by: Iaroslav Ciupin <iaroslav@union.ai>

Add node_name to the container selector (flyteorg#7036)

7902aec

To facilitate getting logs just for a single node, add an optional field to the ContainerSelector message. Signed-off-by: Eugene Yakubovich <eyakubovich@gmail.com>

Migrate flyteorg#6785 in v1 to v2 (flyteorg#6918)

e001908

Signed-off-by: Barry Wu <a0987818905@gmail.com>

[Adjsut][v2] PR from fork repo without using a build CI image to check (

ad2a1c4

flyteorg#6845) If PR from the fork repo, do not use the CI image to check. Adjust checking action to local runner. Signed-off-by: SZL741023 <shengzhe.lin@icloud.com>

[Refac][v2] PR from fork repo without using CI image

deba918

Refactor the check generation yaml file, separate the check method when the PR is from fork repo or not. Signed-off-by: SZL741023 <shengzhe.lin@icloud.com>

Update Cargo.lock

8a386d8

Signed-off-by: SZL741023 <shengzhe.lin@icloud.com>

fix: correct the conditional statement should compare boolean not str…

c79bcb0

…ing (flyteorg#6592) Signed-off-by: SZL741023 <shengzhe.lin@icloud.com>

fix: correct the conditional statement should compare boolean not str…

d630d59

…ing (flyteorg#6592) Signed-off-by: SZL741023 <shengzhe.lin@icloud.com>

chore: update generated files

98af0cd

Signed-off-by: SZL741023 <shengzhe.lin@icloud.com>

fix: fixed the variable type of checking docker image is modified or not

012bbae

Signed-off-by: SZL741023 <shengzhe.lin@icloud.com>

Merge branch 'v2_git_workflow_dev' of github.com:SZL741023/flyte into…

a16d85a

… v2_git_workflow_dev Signed-off-by: SZL741023 <shengzhe.lin@icloud.com>

SZL741023 mentioned this pull request Mar 18, 2026

[v2][Feat] Add the check-generate workflow can work in local runner for the PR from fork repo (#6845) #7040

Open

3 tasks

SZL741023 closed this Mar 18, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Adjsut][v2] PR from fork repo without using a build CI image to check#6952

[Adjsut][v2] PR from fork repo without using a build CI image to check#6952
SZL741023 wants to merge 43 commits intoflyteorg:v2from
SZL741023:v2_git_workflow_dev

SZL741023 commented Mar 1, 2026 •

edited by github-actions bot

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

SZL741023 commented Mar 18, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

11 participants

Conversation

SZL741023 commented Mar 1, 2026 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Tracking issue

Why are the changes needed?

What changes were proposed in this pull request?

How was this patch tested?

Labels

Setup process

Screenshots

Check all the applicable boxes

Related PRs

Docs link

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

SZL741023 commented Mar 18, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

11 participants

SZL741023 commented Mar 1, 2026 •

edited by github-actions bot

Loading