[v2][Feat] Add the check-generate workflow can work in local runner for the PR from fork repo (#6845)#7040
Open
SZL741023 wants to merge 2 commits intoflyteorg:v2from
Open
[v2][Feat] Add the check-generate workflow can work in local runner for the PR from fork repo (#6845)#7040SZL741023 wants to merge 2 commits intoflyteorg:v2from
SZL741023 wants to merge 2 commits intoflyteorg:v2from
Conversation
Adjust check-generate workflow that will call other workflows and check other workflows will be failure or not Separate original check-generate workflow to check-generate-container.yml and rename to check-generate-container Add new workflow file check-generate-local.yml for the PR from fork repo Signed-off-by: SZL741023 <shengzhe.lin@icloud.com>
If the PR from fork repo, don't to rebuild the ci image Signed-off-by: SZL741023 <shengzhe.lin@icloud.com>
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tracking issue
Related to: (#6845)
Original PR: (#6952)
Why are the changes needed?
In original work flow, if files
gen.Dockerfileandbuild-ci-image.ymlhave been changed, the action for build ci image will be trigger. The action for check generation will be exercise after a new ci image is built.If the PR from fork repo, the ci image should not be rebuild and the check generate will be run in local runner.
What changes were proposed in this pull request?
build-ci-image.ymladd the condition to check the PR is from the same repo or fork repo.If PR is from fork repo, build ci image will be skip.
check-generation.ymladd the condition to check the PR is from fork repo or not, and addneeds: [check-generate-conatiner, check-generate-local]to call these workflows with the check fork repo condition and monitor these workflow will be failure or not.Add two workflows files
check-generate-container.ymlandcheck-generate-local.ymlfile and trigger by workflow call.One does check generate in container, the other one does check generate in local runner.
Add the
extract()function incheck-generate-local.ymlto extract the tool versions from gen.Dockerfile to ensure that the correct version information is used.How was this patch tested?
Ensure the PR from fork repo will not trigger the action for build ci image, and check generation will be run in locally runner.
Labels
Please add one or more of the following labels to categorize your PR:
This is important to improve the readability of release notes.
Setup process
Screenshots
Check all the applicable boxes
Related PRs
Docs link
mainmake genmore robust #6845) 👈