fix(notifications): refresh sidebar badge when marking as read#478
Merged
Conversation
…s read
The sidebar badge reads from the useCall-based unreadNotifications resource
in data/notifications.ts, but Notifications.vue was reloading via
$getResource('Unread Notifications Count'), which targets the legacy
createResource cache. The two registries are separate, so the new
useCall resource never refreshed and the badge stayed stale until reload.
Fixes #365
gameplan
 |
||||||||||||||||||||||||||||||
| Project |
gameplan
|
| Branch Review |
fix/notification-count-stale
|
| Run status |
|
| Run duration | 00m 59s |
| Commit |
|
| Committer | Faris Ansari |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
 |
0
|
 |
0
|
 |
0
|
 |
0
|
 |
7
|
Upgrade your plan to view test results. | |
| View all changes introduced in this branch ↗︎ | |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Notifications.vuereloaded viathis.\$getResource('Unread Notifications Count'), which only looks up the legacycreateResourcecache. The actual sidebar badge reads from theuseCall-basedunreadNotificationsresource infrontend/src/data/notifications.ts, which lives in a separate registry and was never being refreshed.unreadNotificationsdirectly and call.reload()on it frommarkAsRead,markAllAsRead, andmounted().Fixes #365
Test plan
1.0without a page reload.🤖 Generated with Claude Code