fix: Increase WebSocket/NTP heartbeat timeout to 30s (Fixes #93)#98
Open
biplavbarua wants to merge 1 commit intofreeman-jiang:mainfrom
Open
fix: Increase WebSocket/NTP heartbeat timeout to 30s (Fixes #93)#98biplavbarua wants to merge 1 commit intofreeman-jiang:mainfrom
biplavbarua wants to merge 1 commit intofreeman-jiang:mainfrom
Conversation
|
@biplavbarua is attempting to deploy a commit to the freemanjiang's projects Team on Vercel. A member of the Team first needs to authorize it. |
biplavbarua
commented
Jan 14, 2026
Author
biplavbarua
left a comment
There was a problem hiding this comment.
LGTM! 🚀
I checked the usage in useNtpHeartbeat.ts (Client) and RoomManager.ts (Server).
- Client: effectively debounces the "Connection Stale" state, which is exactly what we need for the file picker blocking the main thread.
- Server:
hasActiveConnections()uses this constant, so rooms will stay "alive" for 30s after the last heartbeat. This seems like a perfectly acceptable trade-off to prevent false positives during transient network issues.
Good fix.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes Issue #93 where the room disconnects during file uploads or when the browser is paused (e.g. file picker).
Changes:
RESPONSE_TIMEOUT_MSinpackages/shared/constants.tsfrom ~3.75s to 30s.Verification: