Skip to content

fix: Increase WebSocket/NTP heartbeat timeout to 30s (Fixes #93) #98

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
biplavbarua wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: Increase WebSocket/NTP heartbeat timeout to 30s (Fixes #93) #98

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion packages/shared/constants.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,8 @@ export const NTP_CONSTANTS = {
// Steady state interval after initial measurements
STEADY_STATE_INTERVAL_MS: STEADY_STATE_INTERVAL_MS,
// Timeout before considering connection stale
RESPONSE_TIMEOUT_MS: 1.5 * STEADY_STATE_INTERVAL_MS,
// Increased to 12x (30s) to prevent disconnects during file picker selection or slow network (Issue #93)
RESPONSE_TIMEOUT_MS: 12 * STEADY_STATE_INTERVAL_MS,
// Maximum number of NTP measurements to collect initially
MAX_MEASUREMENTS: 40,
} as const;
Expand Down