Refactor USD class transfer to use EIP-712 signing#148
Open
BillyWooo wants to merge 3 commits intohyperliquid-dex:masterfrom
Open
Refactor USD class transfer to use EIP-712 signing#148BillyWooo wants to merge 3 commits intohyperliquid-dex:masterfrom
BillyWooo wants to merge 3 commits intohyperliquid-dex:masterfrom
Conversation
Replace the old SpotUser/ClassTransfer implementation with a new UsdClassTransfer action that uses proper EIP-712 typed data signing. This aligns with the Hyperliquid API's expected signature format, aswell as keeping alignment with hyperliquid-python-sdk. Key changes: - Add UsdClassTransfer struct with EIP-712 implementation - Remove deprecated SpotUser and ClassTransfer structs - Update usd_class_transfer() to use sign_typed_data instead of sign_l1_action - Handle vault_address properly (set to None for usdClassTransfer actions) - Support subaccount suffix in amount string for vault transfers - Add comprehensive tests for signing with mainnet/testnet and vault scenarios
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace the old SpotUser/ClassTransfer implementation with a new UsdClassTransfer action that uses proper EIP-712 typed data signing. This aligns with the Hyperliquid API's expected signature format, aswell as keeping alignment with hyperliquid-python-sdk.
Key changes: