Skip to content

Replaced useAxios with useQuery in CooperationNotes #3288

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
ArtemHolikov wants to merge 10 commits into
base: develop
Choose a base branch
from
Open

Replaced useAxios with useQuery in CooperationNotes #3288

ArtemHolikov wants to merge 10 commits into from

Conversation

@ArtemHolikov
Copy link
Contributor

@ArtemHolikov ArtemHolikov commented Mar 26, 2025 •
edited by yur4uwe
Loading

  • Replaced useAxios with useQuery
  • Fixed tests
  • Refactored component a bit
2025-03-22.14-51-30.mp4

@ArtemHolikov ArtemHolikov self-assigned this Mar 26, 2025
@ArtemHolikov ArtemHolikov linked an issue Mar 26, 2025 that may be closed by this pull request
Replace useAxios with useQuery in CooperationNotes component #3264
Open
@Mike-Popovych
Copy link
Contributor

Mike-Popovych commented Mar 26, 2025

image
Why does this file have a .spec extension?

@Mike-Popovych
Copy link
Contributor

Mike-Popovych commented Mar 26, 2025

image
Please, rename the task

@Mike-Popovych
Copy link
Contributor

Mike-Popovych commented Mar 26, 2025

Write the description for this pr

Mike-Popovych
Mike-Popovych requested changes Mar 26, 2025
View reviewed changes
ShadowOfTheSpace
ShadowOfTheSpace reviewed Mar 26, 2025
View reviewed changes
Copy link
Contributor

@ShadowOfTheSpace ShadowOfTheSpace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, don't forget to fix those comments.

@ShadowOfTheSpace
Copy link
Contributor

ShadowOfTheSpace commented Mar 26, 2025

image Why does this file have a .spec extension?

Agree, it's not a test file.

Mike-Popovych
Mike-Popovych requested changes Apr 2, 2025
View reviewed changes
Mike-Popovych
Mike-Popovych requested changes Apr 2, 2025
View reviewed changes
ShadowOfTheSpace
ShadowOfTheSpace reviewed Apr 2, 2025
View reviewed changes
@sonarqubecloud
Copy link

sonarqubecloud bot commented Apr 3, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
98.3% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

ShadowOfTheSpace
ShadowOfTheSpace reviewed Apr 9, 2025
View reviewed changes
src/services/cooperation-service.ts Outdated
Comment on lines 2 to 11
import {
type CreateCooperationsParams,
type GetCooperationsParams,
type UpdateCooperationsParams,
type CreateOrUpdateNoteParams,
type UpdateCooperationsSections,
type UpdateCooperationsNeedActionMessages,
type Cooperation,
type ItemsWithCount,
type NoteResponse
Copy link
Contributor

@ShadowOfTheSpace ShadowOfTheSpace Apr 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did you changed that?

@ShadowOfTheSpace ShadowOfTheSpace mentioned this pull request Apr 11, 2025
Merged
@lizabre lizabre self-assigned this May 5, 2025
@lizabre lizabre force-pushed the feature/3264/replace-useaxios-usequery-cooperation-notes branch from fc35099 to 9b37fc8 Compare May 8, 2025 12:06
@sonarqubecloud
Copy link

sonarqubecloud bot commented May 8, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
98.4% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@ShadowOfTheSpace
Copy link
Contributor

ShadowOfTheSpace commented May 8, 2025

Why do you have resolved conflicts commit? Is it a merge commit or rebase was incorrect and you fixed things there?

@lizabre
Copy link
Contributor

lizabre commented May 8, 2025

Why do you have resolved conflicts commit? Is it a merge commit or rebase was incorrect and you fixed things there?

this commit was made because of rebase as it had conflicts with the 'develop' branch

@ShadowOfTheSpace
Copy link
Contributor

ShadowOfTheSpace commented May 8, 2025

Why do you have resolved conflicts commit? Is it a merge commit or rebase was incorrect and you fixed things there?

this commit was made because of rebase as it had conflicts with the 'develop' branch

Have you tried to resolve conflicts while you are doing a rebase?

@lizabre
Copy link
Contributor

lizabre commented May 8, 2025

Why do you have resolved conflicts commit? Is it a merge commit or rebase was incorrect and you fixed things there?

this commit was made because of rebase as it had conflicts with the 'develop' branch

Have you tried to resolve conflicts while you are doing a rebase?

yes, I have. Sorry, just realised that this commit was made when I tried to pull the branch locally

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ShadowOfTheSpace ShadowOfTheSpace ShadowOfTheSpace left review comments

@Mike-Popovych Mike-Popovych Mike-Popovych approved these changes

@markgol777 markgol777 Awaiting requested review from markgol777

@PavloButynets PavloButynets Awaiting requested review from PavloButynets

@nebby2105 nebby2105 Awaiting requested review from nebby2105

@SofiiaYevush SofiiaYevush Awaiting requested review from SofiiaYevush

@VKormylo VKormylo Awaiting requested review from VKormylo

At least 3 approving reviews are required to merge this pull request.

Assignees

@ArtemHolikov ArtemHolikov

@lizabre lizabre

Labels

feature Frontend part

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Replace useAxios with useQuery in CooperationNotes component

5 participants

@ArtemHolikov @Mike-Popovych @ShadowOfTheSpace @lizabre