-
Notifications
You must be signed in to change notification settings - Fork 1k
add helm index v1.16.0 #6990
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add helm index v1.16.0 #6990
Conversation
Signed-off-by: zhzhuang-zju <[email protected]>
Summary of ChangesHello @zhzhuang-zju, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request updates the Helm chart index to incorporate the latest Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates the Helm chart index to include the new v1.16.0 release for both karmada and karmada-operator charts. The changes are mostly correct and follow the established structure. However, I've found a minor inconsistency in the generated timestamps which might indicate a small issue in the release process. Please see my detailed comment.
| karmada-operator: | ||
| - apiVersion: v2 | ||
| appVersion: v1.16.0 | ||
| created: "2025-12-02T15:56:05.935993782+08:00" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The created timestamp for this chart entry is slightly later than the generated timestamp at the end of the file (line 575). The generated timestamp should be greater than or equal to all created timestamps in the index. This minor discrepancy suggests a potential issue in the release process, like clock skew or command ordering. Ensuring the generated timestamp is always the latest will improve the index file's integrity.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The generated timestamp should be greater than or equal to all created timestamps in the index
Not exactly, and it was auto-generated by the command helm repo index.
RainbowMango
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: RainbowMango The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Sharing my prompt for using an agent to update the Helm index. # Role
Professional Helm maintainer
# Task
After a new release, update the Helm chart index for `karmada` and `karmada-operator`.
# Context
The Helm index enables clients to discover and query charts in the repository, including version information, descriptions, and other metadata.
## Index path
`charts/index.yaml`
## karmada path
`charts/karmada`
## karmada-operator path
`charts/karmada-operator`
## Entries
Two entries: `karmada` and `karmada-operator`
# Instructions
Strictly follow the steps below to update the chart index:
1. Download the new version of the `karmada` chart package from the GitHub Karmada release assets using the URL:
`https://github.com/karmada-io/karmada/releases/download/{{version}}/karmada-chart-{{version}}.tgz`
Save it under the directory `charts/karmada/`.
2. Run:
helm repo index charts/karmada --url https://github.com/karmada-io/karmada/releases/download/{{version}} --merge charts/index.yaml
3. Run:
mv charts/karmada/index.yaml charts/index.yaml
4. Remove the auto-generated code block under the `entries.common` field in the updated `index.yaml`.
5. The above completes the index update for the `karmada` chart.
6. Repeat the same steps (1–4) to update the index for the `karmada-operator` chart.
7. cleanup: Removed the downloaded chart files to keep the workspace clean
# Note
Keep the indentation unchanged. |
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #6990 +/- ##
==========================================
- Coverage 46.61% 46.60% -0.01%
==========================================
Files 699 699
Lines 48156 48156
==========================================
- Hits 22447 22445 -2
- Misses 24014 24016 +2
Partials 1695 1695
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
What type of PR is this?
/kind feature
What this PR does / why we need it:
Update helm index
Which issue(s) this PR fixes:
Part of #6949
Special notes for your reviewer:
Does this PR introduce a user-facing change?: