fix(observability): unmask Error objects in PinoLoggerService#158
Merged
Conversation
NestJS' ExceptionHandler passes the thrown Error object to logger.error()
on module/DI/bootstrap failures. format() did JSON.stringify() for
non-strings, and JSON.stringify(new Error("boom")) === "{}" (Error's
message/stack are non-enumerable) — so the real cause was masked as
"[ExceptionHandler] {}". format() also threw on circular objects, which
could crash the logger.
- error(): unwrap Error → log its message + preserve the stack.
- format(): Error → message; non-serialisable (circular/BigInt) →
String() fallback instead of throwing.
Adds tests/stories/pino-logger-service.story.test.ts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes
PinoLoggerService.format()masking thrown Error objects as[ExceptionHandler] {}on module/DI/bootstrap failures (JSON.stringify(error) === '{}' — Error props are non-enumerable).error()now unwraps Error → message + preserves stack;format()falls back to String() for circular/non-serialisable payloads instead of throwing. This masking hid a realstorageDefault=rustfs/s3boot failure (missing @aws-sdk) for a downstream consumer. Adds tests/stories/pino-logger-service.story.test.ts (string passthrough, Error-unmask, circular no-throw). Local gates green: lint (0 errors), story test 3/3, test:types.