Skip to content

fix 'make menuconfig' requires the ncurses libraries issue on fedora#90

Open
funcnet wants to merge 1 commit intomirror:masterfrom
funcnet:fix/ncureses_missing_on_fedora
Open

fix 'make menuconfig' requires the ncurses libraries issue on fedora#90
funcnet wants to merge 1 commit intomirror:masterfrom
funcnet:fix/ncureses_missing_on_fedora

Conversation

@funcnet
Copy link
Copy Markdown

@funcnet funcnet commented Jul 14, 2024

fix 'make menuconfig' requires the ncurses libraries issue on fedora. refer to https://bbs.archlinux.org/viewtopic.php?id=295859

@42-Slices-of-Cheese
Copy link
Copy Markdown

From my experience, this also fixes the issue on arch as well.

@marykarampour
Copy link
Copy Markdown

This fixes the error in Ubuntu as well.

Copy link
Copy Markdown

@marykarampour marykarampour left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixes the issue in Ubuntu.

$cc -x c - -o $tmp 2>/dev/null <<'EOF'
#include CURSES_LOC
main() {}
int main() {}
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you are defining main() as returning int, you should probably also add a return 0; to avoid any warnings about it not returning a value that some compilers may throw. This would obviously become fatal if -Werror is active as well. It is probably not significant in the current usage, but not returning a value can also sometimes cause random return values. This would mean potential unexpected failures in the future if something decides to execute this build or test the exit code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants