Skip to content

fix 'make menuconfig' requires the ncurses libraries issue on fedora #90

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
funcnet wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix 'make menuconfig' requires the ncurses libraries issue on fedora #90

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion scripts/kconfig/lxdialog/check-lxdialog.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ trap "rm -f $tmp" 0 1 2 3 15
check() {
$cc -x c - -o $tmp 2>/dev/null <<'EOF'
#include CURSES_LOC
main() {}
int main() {}
Copy link
Copy Markdown

@gissf1 gissf1 Jun 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you are defining main() as returning int, you should probably also add a return 0; to avoid any warnings about it not returning a value that some compilers may throw. This would obviously become fatal if -Werror is active as well. It is probably not significant in the current usage, but not returning a value can also sometimes cause random return values. This would mean potential unexpected failures in the future if something decides to execute this build or test the exit code.

EOF
if [ $? != 0 ]; then
echo " *** Unable to find the ncurses libraries or the" 1>&2
Expand Down