Skip to content

Conversation

@kpavlov
Copy link
Contributor

@kpavlov kpavlov commented Dec 8, 2025

Changes

Fix flaky StdioClientTransportErrorHandlingTest

Use non-empty buffer for reliability

How Has This Been Tested?

Unit test

Breaking Changes

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update

Checklist

  • I have read the MCP Documentation
  • My code follows the repository's style guidelines
  • New and existing tests pass locally
  • I have added appropriate error handling
  • I have added or updated documentation as needed

Additional context

Use non-empty buffer for reliability.
fun `Send should handle exceptions`(throwable: Throwable, shouldWrap: Boolean, expectedCode: Int?) = runTest {
val sendChannel: Channel<JSONRPCMessage> = mockk(relaxed = true)

val stdin = createNonEmptyBuffer { "id: 1\ndata:\n" }
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the fix

@github-actions
Copy link

github-actions bot commented Dec 8, 2025

TestsPassed ✅Skipped ⚠️FailedTime ⏱
JUnit Test Report3417 ran3328 passed89 skipped4m 47s 586ms
TestResultTime ⏱
No test annotations available

@kpavlov kpavlov marked this pull request as ready for review December 8, 2025 11:52
Copy link
Contributor

@tiginamaria tiginamaria left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@kpavlov kpavlov merged commit 1744e16 into main Dec 8, 2025
5 of 6 checks passed
@kpavlov kpavlov deleted the kpavlov/fix-flaky-test branch December 8, 2025 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants