Skip to content

Fix flaky StdioClientTransportErrorHandlingTest #457

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kpavlov merged 1 commit into from
Dec 8, 2025
+14 −5
Merged

Fix flaky StdioClientTransportErrorHandlingTest #457

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 14 additions & 5 deletions .../io/modelcontextprotocol/kotlin/sdk/client/stdio/StdioClientTransportErrorHandlingTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,8 +41,9 @@ class StdioClientTransportErrorHandlingTest {
val stderrBuffer = Buffer()
// Empty stderr = immediate EOF

val inputBuffer = Buffer()
inputBuffer.writeString("""data: {"jsonrpc":"2.0","method":"ping","id":1}\n\n""")
val inputBuffer = createNonEmptyBuffer {
"""data: {"jsonrpc":"2.0","method":"ping","id":1}\n\n"""
}
val outputBuffer = Buffer()

transport = StdioClientTransport(
Expand All @@ -66,8 +67,9 @@ class StdioClientTransportErrorHandlingTest {

@Test
fun `should call onClose exactly once on error scenarios`() = runTest {
val stderrBuffer = Buffer()
stderrBuffer.write("FATAL: critical error\n".encodeToByteArray())
val stderrBuffer = createNonEmptyBuffer {
"FATAL: critical error\n"
}

val inputBuffer = Buffer()
val outputBuffer = Buffer()
Expand Down Expand Up @@ -149,8 +151,9 @@ class StdioClientTransportErrorHandlingTest {
fun `Send should handle exceptions`(throwable: Throwable, shouldWrap: Boolean, expectedCode: Int?) = runTest {
val sendChannel: Channel<JSONRPCMessage> = mockk(relaxed = true)

val stdin = createNonEmptyBuffer { "id: 1\ndata:\n" }
Copy link
Contributor Author

@kpavlov kpavlov Dec 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the fix

transport = StdioClientTransport(
input = Buffer(),
input = stdin,
output = Buffer(),
sendChannel = sendChannel,
)
Expand All @@ -173,4 +176,10 @@ class StdioClientTransportErrorHandlingTest {
exception shouldBeSameInstanceAs throwable
}
}

fun createNonEmptyBuffer(block: () -> String): Buffer {
val buffer = Buffer()
buffer.writeString(block())
return buffer
}
}
Loading