Skip to content

Conversation

@aduh95
Copy link
Contributor

@aduh95 aduh95 commented Nov 17, 2025

Another followup of #60125

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Nov 17, 2025
@codecov
Copy link

codecov bot commented Nov 17, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.57%. Comparing base (411ce7e) to head (4a4fdcf).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #60761      +/-   ##
==========================================
+ Coverage   88.53%   88.57%   +0.03%     
==========================================
  Files         703      703              
  Lines      208259   208259              
  Branches    40169    40178       +9     
==========================================
+ Hits       184391   184458      +67     
+ Misses      15871    15824      -47     
+ Partials     7997     7977      -20     

see 34 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@aduh95 aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Nov 18, 2025
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 18, 2025
@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@aduh95 aduh95 force-pushed the must-call-mustCalls-n branch from eb58e56 to 4a4fdcf Compare November 24, 2025 22:48
@aduh95
Copy link
Contributor Author

aduh95 commented Nov 24, 2025

Landed in 4a4fdcf

@aduh95 aduh95 merged commit 4a4fdcf into nodejs:main Nov 24, 2025
20 of 21 checks passed
@aduh95 aduh95 deleted the must-call-mustCalls-n branch November 24, 2025 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants