fix: make the plugin work with the forum #2
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This includes two fixes (see individual commits) - please don't squash merge:
fix: override FORUM_SEARCH_BACKEND
The Tutor forum plugin hardcodes FORUM_SEARCH_BACKEND to Meilisearch,
so we need to override it here,
otherwise the forum will continue to use Meilisearch.
and
fix: increase Typesense max-per-page server option
The forum sets a constant search comment count of 1000
( https://github.com/openedx/forum/blob/51ec507/forum/constants.py ),
and the Elasticsearch and Meilisearch backends respect that.
So to use this value for Typesense too,
we need to increase the max-per-page server option.
The default is 250 in Typesense.
Supporting information
Test instructions
Rough instructions for setting up the devstack:
Deadline
None