Skip to content

Conversation

@martincostello
Copy link
Member

@martincostello martincostello commented Nov 26, 2025

Description:

Update the version to match autoinstrumentation/dotnet/version.txt as the comment says it should.

# Represents the current release of DotNet instrumentation.
# Should match autoinstrumentation/dotnet/version.txt
autoinstrumentation-dotnet=1.2.0

I found this after I looked in the release notes, and it says .NET was 1.2.0 not 1.12.0 that I'd expected.

.NET auto-instrumentation - v1.2.0

/cc @Kielek as I assume this should have been part of #4527 (and other previous PRs?)

Link to tracking Issue(s): N/A

  • Resolves: N/A

Testing: None - I assume Ci will pick up anything.

Documentation: None

Update the version to match `autoinstrumentation/dotnet/version.txt`.
@martincostello martincostello requested a review from a team as a code owner November 26, 2025 15:40
Copilot AI review requested due to automatic review settings November 26, 2025 15:40
Copilot finished reviewing on behalf of martincostello November 26, 2025 15:41
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the .NET auto-instrumentation version from 1.2.0 to 1.13.0 in versions.txt to match the version specified in autoinstrumentation/dotnet/version.txt, as indicated by the comment in the file.

  • Updates autoinstrumentation-dotnet version from 1.2.0 to 1.13.0

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@martincostello martincostello changed the title Update autoinstrumentation-dotnet to 1.13.0 [chore] Update autoinstrumentation-dotnet to 1.13.0 Nov 26, 2025
@Kielek
Copy link
Member

Kielek commented Nov 26, 2025

@martincostello, we have introduced breaking changes in 1.3.0 related to http semantic convention.
Operator team decided not to include it by default. I am not sure if anything changed last years.

@martincostello
Copy link
Member Author

Should I just update the comment then in the text file then? Otherwise it just looks like a bug.

Should there be an issue to track updating the version at some point in the future? Feels weird to me for the default to be so out of date and for new users to actively need to override what they get out-of-the box.

@pavolloffay
Copy link
Member

We could update the comment, but it is also documented here https://github.com/open-telemetry/opentelemetry-operator/blob/main/RELEASE.md#release-instructions

@martincostello
Copy link
Member Author

I'll update the comment (and fix the broken warning in that document), as if it did't say it should match, I wouldn't have opened this PR in the first place as it would have been clear they're not intended to match. Given I wasn't preparing a release (and I can't as I'm not a maintainer here), there's no reason to expect I'd have been reading the release instructions.

martincostello added a commit to martincostello/opentelemetry-operator that referenced this pull request Nov 27, 2025
- Update comments to avoid people trying to update values that appear wrong.
- Fix broken warning in RELEASE.md.

See open-telemetry#4530.
@martincostello
Copy link
Member Author

#4532

@martincostello martincostello deleted the bump-autoinstrumentation-dotnet branch November 27, 2025 14:54
pavolloffay pushed a commit that referenced this pull request Nov 28, 2025
- Update comments to avoid people trying to update values that appear wrong.
- Fix broken warning in RELEASE.md.

See #4530.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants