Skip to content

Conversation

@martincostello
Copy link
Member

Description:

  • Update comments to avoid people trying to update values that appear wrong.
  • Fix broken warning rendering in RELEASE.md. Whitespace needs to be added around it to render, which breaks the list numbering, so I just added an emoji and some bold instead.

Link to tracking Issue(s):

See #4530.

Testing: Checked markdown rendering in GitHub.

Documentation:

Updated as described above.

- Update comments to avoid people trying to update values that appear wrong.
- Fix broken warning in RELEASE.md.

See open-telemetry#4530.
Copilot AI review requested due to automatic review settings November 27, 2025 14:54
@martincostello martincostello requested a review from a team as a code owner November 27, 2025 14:54
Copilot finished reviewing on behalf of martincostello November 27, 2025 14:56
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates documentation comments in versions.txt and improves the warning formatting in RELEASE.md to clarify version pinning requirements for Java and .NET autoinstrumentation packages.

  • Updated comments for Java and .NET versions to explain why they differ from corresponding version.txt files
  • Changed warning format from GitHub alert syntax to emoji+bold for better rendering

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
versions.txt Updated comments for Java (line 17) and .NET (line 29) to clarify version constraints instead of referencing version.txt files
RELEASE.md Changed warning format from [!WARNING] syntax to emoji and bold formatting to ensure proper markdown rendering

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 27, 2025

E2E Test Results

 34 files  ±0  227 suites  ±0   2h 0m 6s ⏱️ + 2m 21s
 90 tests ±0   90 ✅ ±0  0 💤 ±0  0 ❌ ±0 
231 runs  ±0  231 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 8bc5d2d. ± Comparison against base commit bc8ff58.

♻️ This comment has been updated with latest results.

@pavolloffay pavolloffay merged commit 91fd33e into open-telemetry:main Nov 28, 2025
92 of 95 checks passed
@martincostello martincostello deleted the update-version-docs branch November 28, 2025 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants