Skip to content

Conversation

@cijothomas
Copy link
Member

@cijothomas cijothomas commented Dec 8, 2025

Temp fix for #1549

#1511 introduced a dispatcher to send metrics via OTel, which is resetting the internal state of metrics, thereby affecting the perf tests that rely on cumulative nature of these metrics.

This PR modifies the otel part to just do read, without resetting. This should fix the perf tests that was broken last couple of days.

@cijothomas cijothomas requested a review from a team as a code owner December 8, 2025 22:51
@github-actions github-actions bot added the rust Pull requests that update Rust code label Dec 8, 2025
@codecov
Copy link

codecov bot commented Dec 8, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.75%. Comparing base (02c327d) to head (f1624b8).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1552      +/-   ##
==========================================
- Coverage   83.77%   83.75%   -0.03%     
==========================================
  Files         433      433              
  Lines      122633   122633              
==========================================
- Hits       102739   102706      -33     
- Misses      19360    19393      +33     
  Partials      534      534              
Components Coverage Δ
otap-dataflow 85.03% <100.00%> (-0.05%) ⬇️
query_abstraction 80.61% <ø> (ø)
query_engine 90.31% <ø> (ø)
syslog_cef_receivers ∅ <ø> (∅)
otel-arrow-go 53.50% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@albertlockett albertlockett added this pull request to the merge queue Dec 9, 2025
@jmacd jmacd added the pipelineperf Trigger for the pipeline performance job on PRs label Dec 9, 2025
Merged via the queue into open-telemetry:main with commit 01fa772 Dec 9, 2025
36 checks passed
@cijothomas cijothomas deleted the cijothomas/fixotelintegratin branch December 9, 2025 02:34
github-merge-queue bot pushed a commit that referenced this pull request Dec 9, 2025
… readers (#1555)

~Alternate to #1552 
Since perf tests don't create service/telemetry, this will also unblock
perf tests.~

Simple optimization- avoid the thread creation if there are no readers.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pipelineperf Trigger for the pipeline performance job on PRs rust Pull requests that update Rust code

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants