fix: add missing space symbol to the 'additional.help.text' field #1521

bydawen · 2025-07-14T10:46:40Z

There is a issue, that almost in all translations there is no space between "additional.help.text" field and {getConfig().INFO_EMAIL} in the frontend-app-authn

To prevent this, and not to fix all translations files, space symbol was added.

openedx-webhooks · 2025-07-14T10:46:46Z

Thanks for the pull request, @bydawen!

This repository is currently maintained by @openedx/2u-infinity.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
- This process (including the steps you'll need to take) is documented here.
If it doesn't, simply proceed with the next step.

🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

Dependencies

This PR must be merged before / after / at the same time as ...
Blockers

This PR is waiting for OEP-1234 to be accepted.
Timeline information

This PR must be merged by XX date because ...
Partner information

This is for a course on edx.org.
Supporting documentation
Relevant Open edX discussion forum threads

🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

The size and impact of the changes that it introduces
The need for product review
Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

codecov · 2025-07-14T10:49:13Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 87.57%. Comparing base (882545b) to head (2ba9753).

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #1521   +/-   ##
=======================================
  Coverage   87.57%   87.57%           
=======================================
  Files         125      125           
  Lines        2309     2309           
  Branches      644      648    +4     
=======================================
  Hits         2022     2022           
  Misses        278      278           
  Partials        9        9

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

ihor-romaniuk · 2025-07-21T14:56:14Z

src/forgot-password/ForgotPasswordPage.jsx

              </Hyperlink>
            )}
            <p className="mt-5.5 small text-gray-700">
              {formatMessage(messages['additional.help.text'], { platformName })}


[nit] Please also remove a whitespace in the end of the translation
https://github.com/raccoongang/frontend-app-authn/blob/03af30e8df93caf926f22eb6c0768a215fe07c8f/src/forgot-password/messages.js#L77

[nit] Please also remove a whitespace in the end of the translation https://github.com/raccoongang/frontend-app-authn/blob/03af30e8df93caf926f22eb6c0768a215fe07c8f/src/forgot-password/messages.js#L77

removed, thx!

It looks like this is exactly the issue that this PR is meant to address. Right now, the translation file includes a space between the text For additional help, contact {platformName} support at and the <span> element with the link. While this technically works, and we do see a visible space - it’s not a reliable or correct approach.
It also leads to inconsistencies: in some translations the space may be missing entirely, because it’s not intuitive for translators to include it at the end of a string. That’s why this behavior ends up breaking in certain languages.

sundasnoreen12

Hi @bydawen, Kindly rebase this PR

bydawen · 2025-08-07T17:30:47Z

Hi @bydawen, Kindly rebase this PR

Hello, done)

sundasnoreen12 · 2025-08-11T07:48:01Z

kindly rebase this PR, @bydawen

bydawen · 2025-08-12T06:24:13Z

kindly rebase this PR, @bydawen

Hi, done!

mphilbrick211 · 2025-11-04T19:31:44Z

Hi @bydawen @sundasnoreen12 @ihor-romaniuk @awais-ansari is this still in progress?

PKulkoRaccoonGang

Thanks for the PR! I left a few comments that, in my opinion, clarify the root cause of the issue and outline a potential technical solution that should allow us to land this PR.

PKulkoRaccoonGang · 2025-11-16T14:35:20Z

src/forgot-password/ForgotPasswordPage.jsx

              </Hyperlink>
            )}
            <p className="mt-5.5 small text-gray-700">
              {formatMessage(messages['additional.help.text'], { platformName })}


It looks like this is exactly the issue that this PR is meant to address. Right now, the translation file includes a space between the text For additional help, contact {platformName} support at and the <span> element with the link. While this technically works, and we do see a visible space - it’s not a reliable or correct approach.
It also leads to inconsistencies: in some translations the space may be missing entirely, because it’s not intuitive for translators to include it at the end of a string. That’s why this behavior ends up breaking in certain languages.

PKulkoRaccoonGang · 2025-11-16T14:41:49Z

src/forgot-password/ForgotPasswordPage.jsx

+              &nbsp;
              <span>


Given my earlier comment about the root cause of the spacing issue, I don’t think adding a non-breaking space ( ) is the right long-term solution. Spacing between HTML elements should ideally be handled by CSS whenever possible.

So instead, I’d suggest shifting this responsibility to a Paragon CSS utility class mx-1 which will reliably provide horizontal spacing and will work correctly for both LTR and RTL layouts.

Suggested change

 

<span>

<span class="mx-1">

Given my earlier comment about the root cause of the spacing issue, I don’t think adding a non-breaking space ( ) is the right long-term solution. Spacing between HTML elements should ideally be handled by CSS whenever possible.

So instead, I’d suggest shifting this responsibility to a Paragon CSS utility class mx-1 which will reliably provide horizontal spacing and will work correctly for both LTR and RTL layouts.

fixed, thx!

open-craft-grove · 2025-11-16T15:12:32Z

Sandbox deployment failed 💥
Please check the settings and requirements.
Retry deployment by pushing a new commit or updating the requirements/settings in the pull request's description.
📜 Failure Logs
ℹ️ Grove Config, Tutor Config, Tutor Requirements

open-craft-grove · 2025-11-17T05:49:53Z

Sandbox deployment successful 🚀
🎓 LMS
📝 Studio
ℹ️ Grove Config, Tutor Config, Tutor Requirements

open-craft-grove · 2025-11-26T10:12:36Z

Sandbox deployment failed 💥
Please check the settings and requirements.
Retry deployment by pushing a new commit or updating the requirements/settings in the pull request's description.
📜 Failure Logs
ℹ️ Grove Config, Tutor Config, Tutor Requirements

PKulkoRaccoonGang

LGTM!

open-craft-grove · 2025-11-26T10:35:22Z

Sandbox deployment successful 🚀
🎓 LMS
📝 Studio
ℹ️ Grove Config, Tutor Config, Tutor Requirements

open-craft-grove · 2025-11-26T10:43:49Z

Sandbox deployment successful 🚀
🎓 LMS
📝 Studio
ℹ️ Grove Config, Tutor Config, Tutor Requirements

bydawen requested a review from a team as a code owner July 14, 2025 10:46

openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Jul 14, 2025

openedx-webhooks added this to Contributions Jul 14, 2025

github-project-automation bot moved this to Needs Triage in Contributions Jul 14, 2025

bydawen self-assigned this Jul 14, 2025

mphilbrick211 moved this from Needs Triage to Ready for Review in Contributions Jul 15, 2025

ihor-romaniuk reviewed Jul 21, 2025

View reviewed changes

bydawen force-pushed the fix/missing-space-in-forgot-password-field branch from 668e7fd to 6b9e407 Compare July 21, 2025 15:10

ihor-romaniuk approved these changes Jul 21, 2025

View reviewed changes

sundasnoreen12 suggested changes Aug 7, 2025

View reviewed changes

bydawen force-pushed the fix/missing-space-in-forgot-password-field branch from 6b9e407 to 0466364 Compare August 7, 2025 11:31

awais-ansari approved these changes Aug 8, 2025

View reviewed changes

awais-ansari requested a review from sundasnoreen12 August 8, 2025 12:59

bydawen force-pushed the fix/missing-space-in-forgot-password-field branch from 0466364 to 5cf1541 Compare August 12, 2025 06:23

ihor-romaniuk force-pushed the fix/missing-space-in-forgot-password-field branch 2 times, most recently from 6b035f3 to 2f6e97e Compare August 28, 2025 12:23

awais-ansari requested a review from ihor-romaniuk August 29, 2025 06:51

bydawen force-pushed the fix/missing-space-in-forgot-password-field branch from 2f6e97e to 854904d Compare September 11, 2025 09:38

mphilbrick211 moved this from Ready for Review to In Eng Review in Contributions Sep 16, 2025

mphilbrick211 added the waiting on author PR author needs to resolve review requests, answer questions, fix tests, etc. label Sep 24, 2025

bydawen force-pushed the fix/missing-space-in-forgot-password-field branch from 854904d to 3505e16 Compare October 15, 2025 10:19

mphilbrick211 removed the waiting on author PR author needs to resolve review requests, answer questions, fix tests, etc. label Oct 29, 2025

mphilbrick211 moved this from In Eng Review to Ready for Review in Contributions Oct 29, 2025

mphilbrick211 requested a review from awais-ansari October 29, 2025 22:07

awais-ansari approved these changes Nov 5, 2025

View reviewed changes

PKulkoRaccoonGang added the create-sandbox open-craft-grove should create a sandbox environment from this PR label Nov 16, 2025

PKulkoRaccoonGang suggested changes Nov 16, 2025

View reviewed changes

bydawen force-pushed the fix/missing-space-in-forgot-password-field branch from 3505e16 to 4e9a7c4 Compare November 26, 2025 09:30

fix: add missing space symbol to the 'additional.help.text' field

2ba9753

bydawen force-pushed the fix/missing-space-in-forgot-password-field branch from 4e9a7c4 to 2ba9753 Compare November 26, 2025 09:33

PKulkoRaccoonGang approved these changes Nov 26, 2025

View reviewed changes

mphilbrick211 moved this from Ready for Review to In Eng Review in Contributions Dec 12, 2025

fix: add missing space symbol to the 'additional.help.text' field #1521

Are you sure you want to change the base?

fix: add missing space symbol to the 'additional.help.text' field #1521

Conversation

bydawen commented Jul 14, 2025

Uh oh!

openedx-webhooks commented Jul 14, 2025

Uh oh!

codecov bot commented Jul 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

ihor-romaniuk Jul 21, 2025

Choose a reason for hiding this comment

Uh oh!

bydawen Jul 21, 2025

Choose a reason for hiding this comment

Uh oh!

PKulkoRaccoonGang Nov 16, 2025

Choose a reason for hiding this comment

Uh oh!

sundasnoreen12 left a comment

Choose a reason for hiding this comment

Uh oh!

bydawen commented Aug 7, 2025

Uh oh!

sundasnoreen12 commented Aug 11, 2025

Uh oh!

bydawen commented Aug 12, 2025

Uh oh!

mphilbrick211 commented Nov 4, 2025

Uh oh!

PKulkoRaccoonGang left a comment

Choose a reason for hiding this comment

Uh oh!

PKulkoRaccoonGang Nov 16, 2025

Choose a reason for hiding this comment

Uh oh!

PKulkoRaccoonGang Nov 16, 2025

Choose a reason for hiding this comment

Uh oh!

bydawen Nov 26, 2025

Choose a reason for hiding this comment

Uh oh!

open-craft-grove commented Nov 16, 2025

Uh oh!

open-craft-grove commented Nov 17, 2025

Uh oh!

open-craft-grove commented Nov 26, 2025

Uh oh!

PKulkoRaccoonGang left a comment

Choose a reason for hiding this comment

Uh oh!

open-craft-grove commented Nov 26, 2025

Uh oh!

open-craft-grove commented Nov 26, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

codecov bot commented Jul 14, 2025 •

edited

Loading