Skip to content

fix: add missing space symbol to the 'additional.help.text' field #1521

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bydawen wants to merge 1 commit into
base: master
Choose a base branch
from
+2 −2
Open

fix: add missing space symbol to the 'additional.help.text' field #1521

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/forgot-password/ForgotPasswordPage.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,7 +153,7 @@ const ForgotPasswordPage = (props) => {
)}
<p className="mt-5.5 small text-gray-700">
{formatMessage(messages['additional.help.text'], { platformName })}
Copy link
Contributor

@ihor-romaniuk ihor-romaniuk Jul 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nit] Please also remove a whitespace in the end of the translation
https://github.com/raccoongang/frontend-app-authn/blob/03af30e8df93caf926f22eb6c0768a215fe07c8f/src/forgot-password/messages.js#L77

Copy link
Contributor Author

@bydawen bydawen Jul 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nit] Please also remove a whitespace in the end of the translation https://github.com/raccoongang/frontend-app-authn/blob/03af30e8df93caf926f22eb6c0768a215fe07c8f/src/forgot-password/messages.js#L77

removed, thx!

Copy link

@PKulkoRaccoonGang PKulkoRaccoonGang Nov 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like this is exactly the issue that this PR is meant to address. Right now, the translation file includes a space between the text For additional help, contact {platformName} support at and the <span> element with the link. While this technically works, and we do see a visible space - it’s not a reliable or correct approach.
It also leads to inconsistencies: in some translations the space may be missing entirely, because it’s not intuitive for translators to include it at the end of a string. That’s why this behavior ends up breaking in certain languages.

<span>
<span className="mx-1">
<Hyperlink isInline destination={`mailto:${getConfig().INFO_EMAIL}`}>{getConfig().INFO_EMAIL}</Hyperlink>
</span>
</p>
Expand Down
2 changes: 1 addition & 1 deletion src/forgot-password/messages.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ const messages = defineMessages({
},
'additional.help.text': {
id: 'additional.help.text',
defaultMessage: 'For additional help, contact {platformName} support at ',
defaultMessage: 'For additional help, contact {platformName} support at',
description: 'additional help text on forgot password page',
},
'sign.in.text': {
Expand Down