Skip to content

fix(files-drop): Fix upload confirmation not visible at small viewports#13796

Closed
awabcodes wants to merge 1 commit into
owncloud:masterfrom
awabcodes:fix/OCISDEV-703-improve-files-drop-responsivity
Closed

fix(files-drop): Fix upload confirmation not visible at small viewports#13796
awabcodes wants to merge 1 commit into
owncloud:masterfrom
awabcodes:fix/OCISDEV-703-improve-files-drop-responsivity

Conversation

@awabcodes
Copy link
Copy Markdown
Contributor

@awabcodes awabcodes commented May 19, 2026

Description

Fix a responsive design issue where the upload confirmation message was not visible on the file drop page.

Refactor the layout to use natural document flow instead of fragile height-dependent CSS

Related Issue

Motivation and Context

The upload confirmation message was invisible at small browser window sizes when using file drop links. The UploadInfo panel was placed in a 1fr grid row whose height depended on a broken height: 100% chain from the root element. The oc-overflow hidden wrapper then silently clipped the collapsed panel. This caused users to be unable to confirm their upload succeeded

How Has This Been Tested?

  • test environment: Chrome on macOS,
  • test case 1: Open a file drop link at small viewport, upload a file. confirmation message is now visible immediately
  • test case 2: Resize from large to small viewport after upload. confirmation remains visible
  • ...

Screenshots (if appropriate):

Open tasks:

  • ...

@update-docs
Copy link
Copy Markdown

update-docs Bot commented May 19, 2026

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@awabcodes awabcodes marked this pull request as draft May 19, 2026 15:04
@awabcodes awabcodes closed this May 19, 2026
@awabcodes awabcodes reopened this May 19, 2026
@awabcodes awabcodes marked this pull request as ready for review May 19, 2026 15:09
@LukasHirt LukasHirt self-requested a review May 19, 2026 15:13
Copy link
Copy Markdown
Collaborator

@LukasHirt LukasHirt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@awabcodes awabcodes force-pushed the fix/OCISDEV-703-improve-files-drop-responsivity branch from 2004797 to 790654a Compare May 20, 2026 07:23
@CLAassistant
Copy link
Copy Markdown

CLAassistant commented May 20, 2026

CLA assistant check
All committers have signed the CLA.

@mzner
Copy link
Copy Markdown
Contributor

mzner commented May 20, 2026

@awabcodes Could you please sign the commit?

@awabcodes awabcodes force-pushed the fix/OCISDEV-703-improve-files-drop-responsivity branch from 790654a to bb98145 Compare May 20, 2026 07:53
@awabcodes awabcodes force-pushed the fix/OCISDEV-703-improve-files-drop-responsivity branch from bb98145 to cdac0b0 Compare May 20, 2026 08:08
@awabcodes awabcodes requested a review from LukasHirt May 20, 2026 08:12
@awabcodes awabcodes closed this May 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants