Skip to content

fix(files-drop): Fix upload confirmation not visible at small viewports #13796

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
awabcodes wants to merge 1 commit into from
Closed

fix(files-drop): Fix upload confirmation not visible at small viewports #13796

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions changelog/unreleased/bugfix-files-drop-upload-info-not-visible.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
Bugfix: Fix upload confirmation not visible on file drop page

We've fixed a responsive layout issue where the upload confirmation message was not visible at small browser window sizes on the file drop page. The `UploadInfo` panel was being clipped due to broken CSS. The layout now uses natural document flow so the confirmation is always visible regardless of viewport size.

https://github.com/owncloud/web/pull/13796
9 changes: 3 additions & 6 deletions packages/web-app-files/src/views/FilesDrop.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,10 +35,10 @@
</div>
</div>

<div class="oc-overflow-hidden">
<div>
<upload-info
id="files-drop-upload-info"
class="oc-width-1-1 oc-height-1-1 oc-overflow-hidden oc-display-grid"
class="oc-width-1-1 oc-height-1-1"
:info-expanded-initial="true"
:headless="true"
:show-expand-details-button="false"
Expand Down Expand Up @@ -331,6 +331,7 @@ defineExpose({ loading })
padding: var(--oc-space-medium);
border: none;
position: relative;
overflow-y: auto;

@media (min-width: $oc-breakpoint-small-default) {
border: 3px dashed var(--oc-color-input-border);
Expand Down Expand Up @@ -393,8 +394,4 @@ defineExpose({ loading })
position: absolute;
z-index: 9;
}

#files-drop-upload-info {
grid-template-columns: max-content;
}
</style>
Loading