-
-
Notifications
You must be signed in to change notification settings - Fork 421
[Deps] Bump to PHPStan ^2.1.32 and fix test #7622
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
It seems related with this PHPStan commit: |
|
For PHPStan notice: https://github.com/rectorphp/rector-src/actions/runs/19303603336/job/55204664628?pr=7622#step:5:19 I created PR to |
|
Released https://github.com/symplify/phpstan-extensions/releases/tag/12.0.2 |
|
Fixed PHPStan error on with ignore the apply for now as seems false positive. |
|
For internal error undefined index 0 on |
|
As for the unused private property rector, you should take a look at the way how PHPStan reliably detects unused properties, and do that in Rector https://github.com/phpstan/phpstan-src/blob/013e02184740591e14fbacc1a3b754a1df3767e4/src/Rules/DeadCode/UnusedPrivatePropertyRule.php |
|
@ondrejmirtes thank you, I will check if that possible to check here, as we are using |
|
Fixed PHPUnit error on rector-symfony for internal PHPStan with set attribute->args on AttributeGroup immediatelly there. |
|
Fixed by use |
|
All checks have passed 🎉 @TomasVotruba I am merging it and will create immediate release for it to avoid crash when update phpstan |
|
I've released rector 2.2.8 that include this patch |
New PHPStan release 2.1.32
https://github.com/phpstan/phpstan/releases/tag/2.1.32
cause unit test error
https://github.com/rectorphp/rector-src/actions/runs/19303467511/job/55204152912?pr=7621#step:5:102
This PR try to fix it.