Skip to content

Conversation

@samsonasik
Copy link
Member

@samsonasik samsonasik self-assigned this Nov 12, 2025
@samsonasik
Copy link
Member Author

It seems related with this PHPStan commit:

phpstan/phpstan-src@020adb5

@samsonasik
Copy link
Member Author

samsonasik commented Nov 12, 2025

@samsonasik
Copy link
Member Author

samsonasik commented Nov 12, 2025

Released symplify/phpstan-extensions 12.0.2 and use here so we can focus on fixing unit test:

https://github.com/symplify/phpstan-extensions/releases/tag/12.0.2

@samsonasik
Copy link
Member Author

Fixed PHPStan error on rector-downgrade-php

with ignore the apply for now as seems false positive.

@samsonasik
Copy link
Member Author

For internal error undefined index 0 on ParametersAcceptorSelector, I created PHPStan issue:

samsonasik referenced this pull request in phpstan/phpstan-src Nov 12, 2025
@ondrejmirtes
Copy link
Contributor

As for the unused private property rector, you should take a look at the way how PHPStan reliably detects unused properties, and do that in Rector https://github.com/phpstan/phpstan-src/blob/013e02184740591e14fbacc1a3b754a1df3767e4/src/Rules/DeadCode/UnusedPrivatePropertyRule.php

@samsonasik
Copy link
Member Author

@ondrejmirtes thank you, I will check if that possible to check here, as we are using getType() of PHPStan type.

@samsonasik
Copy link
Member Author

Fixed PHPUnit error on rector-symfony for internal PHPStan ParametersAcceptorSelector error, I fixed at PR:

with set attribute->args on AttributeGroup immediatelly there.

@samsonasik
Copy link
Member Author

Fixed by use getStaticObjectType() for local property fetch detection on PHPStan\Type\StaticType

1e8be38

@samsonasik
Copy link
Member Author

All checks have passed 🎉 @TomasVotruba I am merging it and will create immediate release for it to avoid crash when update phpstan

@samsonasik samsonasik merged commit 5aba21f into main Nov 12, 2025
54 checks passed
@samsonasik samsonasik deleted the bump-phpstan-2132 branch November 12, 2025 18:29
@samsonasik
Copy link
Member Author

I've released rector 2.2.8 that include this patch

https://github.com/rectorphp/rector/releases/tag/2.2.8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants