Skip to content

Conversation

@samsonasik
Copy link
Member

@TomasVotruba during try to fix clone type check on rector-src:

I found that the PHPStan 2.1.32 cause issue on running phpstan itself, and it got on ClassConstFetchReturnTypeResolver

https://github.com/rectorphp/rector-src/actions/runs/19303603336/job/55204664628?pr=7622#step:5:19

running with verbose got error on this part:

if (! isset($methodCall->args[0])) {
throw new ShouldNotHappenException('Not supported without argument');
}

This PR fix it by return null.

@samsonasik
Copy link
Member Author

All checks have passed 🎉 @TomasVotruba I am merging it and will create immediate release so can focus on fixing rector tests :)

@samsonasik samsonasik merged commit 5436bf4 into main Nov 12, 2025
5 checks passed
@samsonasik samsonasik deleted the bump-phpstan-2132 branch November 12, 2025 16:45
@samsonasik
Copy link
Member Author

Released symplify/phpstan-extensions 12.0.2 so we can test on rector side:

https://github.com/symplify/phpstan-extensions/releases/tag/12.0.2

@TomasVotruba
Copy link
Member

👍 Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants