Skip to content

fix: alert submit e2e failures because of reactive superform creation#9042

Closed
AdityaHegde wants to merge 4 commits intomainfrom
fix/alert-submit-e2e-failures
Closed

fix: alert submit e2e failures because of reactive superform creation#9042
AdityaHegde wants to merge 4 commits intomainfrom
fix/alert-submit-e2e-failures

Conversation

@AdityaHegde
Copy link
Copy Markdown
Collaborator

@AdityaHegde AdityaHegde commented Mar 13, 2026

We need to keep the form instance reactive to ensure data from explore updates the alert form. But this is causing issues around submit. Using the form id from the superForms to try and combat this.

Checklist:

  • Covered by tests
  • Ran it and it works as intended
  • Reviewed the diff before requesting a review
  • Checked for unhandled edge cases
  • Linked the issues it closes
  • Checked if the docs need to be updated. If so, create a separate Linear DOCS issue
  • Intend to cherry-pick into the release branch
  • I'm proud of this work!

@AdityaHegde AdityaHegde force-pushed the fix/alert-submit-e2e-failures branch from ceab075 to eb8e53b Compare April 2, 2026 05:40
@AdityaHegde AdityaHegde requested a review from ericpgreen2 April 2, 2026 06:37
@AdityaHegde
Copy link
Copy Markdown
Collaborator Author

This didnt really help

@AdityaHegde AdityaHegde closed this Apr 2, 2026
@AdityaHegde AdityaHegde deleted the fix/alert-submit-e2e-failures branch April 2, 2026 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant