Skip to content

fix: alert submit e2e failures because of reactive superform creation #9042

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
AdityaHegde wants to merge 4 commits into from
Closed

fix: alert submit e2e failures because of reactive superform creation #9042

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b02a48f
fix: alert submit e2e failures because of reactive superform creation
AdityaHegde Mar 13, 2026
a2d1c95
Fix lint
AdityaHegde Mar 13, 2026
9385186
Merge branch 'main' into fix/alert-submit-e2e-failures
AdityaHegde Apr 2, 2026
eb8e53b
Use formId from superForm
AdityaHegde Apr 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions web-admin/tests/alerts.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ test.describe.serial("Alerts", () => {

await adminPage.getByRole("button", { name: "Create alert" }).click();

const alertForm = adminPage.locator("form#create-alert-form");
const alertForm = adminPage.locator("form");

// Select "Last 6 hours" as time range
await interactWithTimeRangeMenu(alertForm, async () => {
Expand Down Expand Up @@ -159,7 +159,7 @@ test.describe.serial("Alerts", () => {
// Edit the alert
await adminPage.getByRole("button", { name: "Edit" }).click();

const alertForm = adminPage.locator("form#edit-alert-form");
const alertForm = adminPage.locator("form");

// Select "Last 24 hours" as time range
await interactWithTimeRangeMenu(alertForm, async () => {
Expand Down Expand Up @@ -291,7 +291,7 @@ test.describe.serial("Alerts", () => {

await adminPage.getByRole("button", { name: "Create alert" }).click();

const alertForm = adminPage.locator("form#create-alert-form");
const alertForm = adminPage.locator("form");

// Select "App Site Name" as split by dimension
await adminPage.getByLabel("Split by dimension", { exact: true }).click();
Expand Down Expand Up @@ -356,7 +356,7 @@ test.describe.serial("Alerts", () => {
// Edit the alert
await adminPage.getByRole("button", { name: "Edit" }).click();

const alertForm = adminPage.locator("form#edit-alert-form");
const alertForm = adminPage.locator("form");

// Go to criteria tab
await alertForm.getByRole("button", { name: "Next" }).click();
Expand Down
7 changes: 3 additions & 4 deletions web-common/src/features/alerts/AlertForm.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,10 +153,9 @@
invalidateAll: false,
},
);
$: ({ form, errors, enhance, submit, submitting, tainted, validate } =
$: ({ form, formId, errors, enhance, submitting, submit, tainted, validate } =
superFormInstance);

$: formId = isCreateForm ? "create-alert-form" : "edit-alert-form";
$: dialogTitle = isCreateForm ? "Create Alert" : "Edit Alert";

const tabs = ["Data", "Criteria", "Delivery"];
Expand Down Expand Up @@ -290,7 +289,7 @@
<form
autocomplete="off"
class="flex flex-col gap-y-3"
id={formId}
id={$formId}
onsubmit={(e) => {
e.preventDefault();
submit(e);
Expand Down Expand Up @@ -336,7 +335,7 @@
{#if currentTabIndex !== 2}
<Button type="primary" onClick={handleNextTab}>Next</Button>
{:else}
<Button type="primary" disabled={$submitting} form={formId} submitForm>
<Button type="primary" disabled={$submitting} form={$formId} submitForm>
{isCreateForm ? "Create" : "Update"}
</Button>
{/if}
Expand Down
Loading