refactor: fix pyproject specification & use uv
#10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Bugen Zhao <[email protected]>
Signed-off-by: Bugen Zhao <[email protected]>
Signed-off-by: Bugen Zhao <[email protected]>
Signed-off-by: Bugen Zhao <[email protected]>
Signed-off-by: Bugen Zhao <[email protected]>
BugenZhao
commented
Apr 7, 2025
| requires-python = ">=3.8" | ||
| license = "Apache-2.0" | ||
| license-files = ["LICENSE"] | ||
| requires-python = ">=3.9" |
Member
Author
There was a problem hiding this comment.
pandas==2.2.2 requires Python 3.9.
Comment on lines
+31
to
+37
| # FIXME: Currently, we are building against sqlalchemy 2.0, which is also sqlalchemy-risingwave 1.1.1 | ||
| # depends on. However, there's still some compatibility issues unresolved. | ||
| # We should either: | ||
| # 1. Rewrite this library to use sqlalchemy-risingwave 1.4.0, which depends on sqlalchemy 1.4. | ||
| # 2. Wait for sqlalchemy-risingwave 2.0.0 to be released, which will depend on sqlalchemy 2.0 and | ||
| # resolve the compatibility issues. (https://github.com/risingwavelabs/sqlalchemy-risingwave/issues/22) | ||
| "sqlalchemy-risingwave==1.1.1", |
Member
Author
There was a problem hiding this comment.
Something worth noting.
Comment on lines
+53
to
+57
| [dependency-groups] | ||
| dev = [ | ||
| "psycopg2-binary>=2.9.9", | ||
| "websocket-client>=1.8.0", | ||
| ] |
Member
Author
There was a problem hiding this comment.
To get rid of requirements-dev.txt.
|
|
||
|
|
||
| [projects.urls] | ||
| [project.urls] |
|
|
||
| from sqlalchemy import create_engine, Engine, text, Connection | ||
| from sqlalchemy import create_engine, text | ||
| from sqlalchemy.engine import Connection, Engine |
Member
Author
There was a problem hiding this comment.
Incorrect typing imports.
| except Exception as e: | ||
| ee = e | ||
| logging.warn(f"retrying function, exception: {e}, {traceback.format_exc()}") | ||
| logging.warning(f"retrying function, exception: {e}, {traceback.format_exc()}") |
Member
Author
There was a problem hiding this comment.
Vendor uv.lock to demonstrate all indirect dependencies
BugenZhao
changed the title
Member
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Apr 7, 2025
Merged
BugenZhao
changed the title
uv
Signed-off-by: Bugen Zhao <[email protected]>
stdrc
approved these changes
Apr 7, 2025
hzxa21
approved these changes
Apr 7, 2025
Member
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Bugen Zhao [email protected]
This PR
uvpackage manager for modern developer experience