Skip to content

Conversation

@BugenZhao
Copy link
Member

@BugenZhao BugenZhao commented Apr 7, 2025

Previously, I was confused about what binance is for...

Copy link
Member Author

BugenZhao commented Apr 7, 2025

@BugenZhao BugenZhao mentioned this pull request Apr 7, 2025
@BugenZhao BugenZhao force-pushed the bz/reconstruct branch 2 times, most recently from 1b0a616 to d387952 Compare April 7, 2025 06:53
@BugenZhao BugenZhao marked this pull request as ready for review April 7, 2025 07:45
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (1)

examples/demo.py:113

  • [nitpick] The function name 'demo_boll' may be ambiguous if it is intended to demonstrate Binance functionality. Consider renaming it to 'demo_binance' for improved clarity.
def demo_boll():

Copy link
Member Author

BugenZhao commented Apr 8, 2025

Merge activity

  • Apr 7, 11:45 PM EDT: A user started a stack merge that includes this pull request via Graphite.
  • Apr 7, 11:49 PM EDT: Graphite rebased this pull request as part of a merge.
  • Apr 7, 11:51 PM EDT: A user merged this pull request with Graphite.

@BugenZhao BugenZhao changed the base branch from bz/demo to graphite-base/12 April 8, 2025 03:46
@BugenZhao BugenZhao changed the base branch from graphite-base/12 to main April 8, 2025 03:48
Signed-off-by: Bugen Zhao <[email protected]>
@BugenZhao BugenZhao merged commit 4de934a into main Apr 8, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants