Skip to content

refactor(metric): increase bucket size #23938

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
zwang28 wants to merge 1 commit into from
Closed

refactor(metric): increase bucket size #23938

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docker/dashboards/risingwave-dev-dashboard.json
View file
Open in desktop

Large diffs are not rendered by default.

6 changes: 3 additions & 3 deletions grafana/dashboard/dev/cluster_essential.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -232,11 +232,11 @@ def _(outer_panels: Panels):
["last"],
),
panels.timeseries_count(
"Failed recovery attempts",
"Total number of failed reocovery attempts",
"Recovery Failure Rate",
"The rate of failed recovery attempts",
[
panels.target(
f"sum({metric('recovery_failure_cnt')}) by ({NODE_LABEL}, recovery_type)",
f"sum(rate({metric('recovery_failure_cnt')}[$__rate_interval])) by ({NODE_LABEL}, recovery_type)",
"{{%s}} ({{recovery_type}})" % NODE_LABEL,
)
],
Expand Down
2 changes: 1 addition & 1 deletion grafana/risingwave-dev-dashboard.json
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion src/meta/src/rpc/metrics.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -248,7 +248,7 @@ impl MetaMetrics {
let opts = histogram_opts!(
"meta_barrier_duration_seconds",
"barrier latency",
exponential_buckets(0.1, 1.5, 20).unwrap() // max 221s
exponential_buckets(0.1, 1.5, 24).unwrap() // max 1683s
);
let barrier_latency =
register_guarded_histogram_vec_with_registry!(opts, &["database_id"], registry)
Expand Down
Loading