apollo_l1_provider: remove some panics in the L1 Provider #10411
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
Contributor
Author
guy-starkware
force-pushed
the
guyn/l1provider/remove_panics
branch
2 times, most recently
from
26dccbf to
bf962e1
Compare
guy-starkware
force-pushed
the
guyn/l1provider/remove_panics
branch
from
bf962e1 to
5dbd1de
Compare
This was referenced Dec 2, 2025
apollo_l1_provider: add verification that tx is pending when getting it from proposable index
#10511
Merged
sirandreww-starkware
approved these changes
Dec 3, 2025
Contributor
sirandreww-starkware
left a comment
sirandreww-starkware
left a comment
There was a problem hiding this comment.
Reviewable status: 0 of 3 files reviewed, all discussions resolved
sirandreww-starkware
approved these changes
Dec 3, 2025
Contributor
sirandreww-starkware
left a comment
sirandreww-starkware
left a comment
There was a problem hiding this comment.
@sirandreww-starkware reviewed 3 of 3 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @guy-starkware)
guy-starkware
force-pushed
the
guyn/l1provider/remove_panics
branch
from
5dbd1de to
ccd6e58
Compare
guy-starkware
force-pushed
the
guyn/l1provider/remove_panics
branch
from
ccd6e58 to
67f86a0
Compare
ShahakShama
approved these changes
Dec 8, 2025
Collaborator
ShahakShama
left a comment
ShahakShama
left a comment
There was a problem hiding this comment.
@ShahakShama reviewed all commit messages.
Reviewable status:
This was referenced Dec 10, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.