apollo_l1_provider: add verification that tx is pending when getting it from proposable index

[guy-starkware]

No description provided.

[reviewable-StarkWare]

This change is 

[guy-starkware]

• apollo_l1_provider: replace bootstrapping with catching up #10726
• apollo_l1_provider: rename catch_up_height and historic height #10725
• apollo_l1_provider: scraper historic height is one more #10724
• apollo_l1_provider: minor updates to some bootstrapping tests of the L1 provider #10702
• apollo_l1_provider: add reset_bootstrapper function #10513
• apollo_l1_provider: check for uninitialized instead of bootstrapping+sync started #10512
• apollo_l1_provider: add verification that tx is pending when getting it from proposable index #10511 👈 (View in Graphite)
• apollo_l1_provider: improve add_tx and prevent double scraping #10508
• apollo_l1_provider: add l1_block_time as a config parameter #10505
• apollo_l1_provider: change L1_BLOCK_TIME to be 12 seconds #10544
• apollo_l1_provider: fix log message when skipping over historic heights #10465
• apollo_l1_provider: reduce number of provider error variants #10414
• apollo_l1_provider: remove some panics in the L1 Provider #10411
• main-v0.14.1

This stack of pull requests is managed by Graphite. Learn more about stacking.

[sirandreww-starkware]

Reviewable status: 0 of 3 files reviewed, 1 unresolved discussion (waiting on @guy-starkware)

---

crates/apollo_l1_provider/src/transaction_manager.rs line 95 at r1 (raw file):

                    record.state
                );
            }

use assert_ne

Code quote:

            if record.state != TransactionState::Pending {
                panic!(
                    "Transaction {tx_hash} has state {:?}. Only Pending transactions should be in \
                     the proposable index.",
                    record.state
                );
            }

[guy-starkware]

Reviewable status: 0 of 3 files reviewed, 1 unresolved discussion (waiting on @sirandreww-starkware)

---

crates/apollo_l1_provider/src/transaction_manager.rs line 95 at r1 (raw file):

Previously, sirandreww-starkware (Andrew Luka) wrote…

use assert_ne

I think you mean assert_eq! but either way, Done.

[sirandreww-starkware]

Reviewable status: 0 of 3 files reviewed, all discussions resolved

---

crates/apollo_l1_provider/src/transaction_manager.rs line 95 at r1 (raw file):

Previously, guy-starkware wrote…

I think you mean assert_eq! but either way, Done.

yes, sorry

[ShahakShama]

@ShahakShama reviewed 2 of 3 files at r1, 1 of 1 files at r3, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @guy-starkware)

[graphite-app]

Merge activity

• Dec 11, 9:28 AM UTC: Graphite rebased this pull request, because this pull request is set to merge when ready.