Skip to content

apollo_network_benchmark: new crate for benchmarking the p2p network stack #10551

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
sirandreww-starkware merged 1 commit into from
Dec 7, 2025
Merged

apollo_network_benchmark: new crate for benchmarking the p2p network stack #10551

sirandreww-starkware merged 1 commit into from
Dec 7, 2025

Conversation

@sirandreww-starkware
Copy link
Contributor

@sirandreww-starkware sirandreww-starkware commented Dec 3, 2025

No description provided.

@reviewable-StarkWare
Copy link

reviewable-StarkWare commented Dec 3, 2025

This change is Reviewable

@sirandreww-starkware sirandreww-starkware self-assigned this Dec 3, 2025
@sirandreww-starkware sirandreww-starkware marked this pull request as ready for review December 3, 2025 14:35
@sirandreww-starkware Graphite App
Copy link
Contributor Author

sirandreww-starkware commented Dec 3, 2025 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

@sirandreww-starkware sirandreww-starkware mentioned this pull request Dec 3, 2025
Merged
@github-actions
Copy link

github-actions bot commented Dec 3, 2025 •
edited
Loading

Artifacts upload workflows:

@sirandreww-starkware sirandreww-starkware changed the base branch from 12-03-apollo_network_removed_old_network_stress_test_code to graphite-base/10551 December 4, 2025 06:24
@sirandreww-starkware sirandreww-starkware force-pushed the 12-03-apollo_network_benchmark_initial_commit branch from 2602d7d to ab3e735 Compare December 4, 2025 06:24
@sirandreww-starkware sirandreww-starkware changed the base branch from graphite-base/10551 to main December 4, 2025 06:24
@sirandreww-starkware sirandreww-starkware force-pushed the 12-03-apollo_network_benchmark_initial_commit branch from ab3e735 to 09fa84d Compare December 4, 2025 07:14
This was referenced Dec 4, 2025
Merged
Merged
@sirandreww-starkware sirandreww-starkware force-pushed the 12-03-apollo_network_benchmark_initial_commit branch from 09fa84d to 66fb216 Compare December 4, 2025 13:53
ShahakShama
ShahakShama requested changes Dec 7, 2025
View reviewed changes
Copy link
Collaborator

@ShahakShama ShahakShama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ShahakShama reviewed 1 of 3 files at r1, 5 of 5 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @noamsp-starkware and @sirandreww-starkware)

a discussion (no related file):
Please change the PR title (the title is what matters as it will be the message of the commit once we merge) to something more descriptive

@sirandreww-starkware sirandreww-starkware changed the title apollo_network_benchmark: initial commit apollo_network_benchmark: new crate for benchmarking the p2p network stack Dec 7, 2025
sirandreww-starkware
sirandreww-starkware commented Dec 7, 2025
View reviewed changes
Copy link
Contributor Author

@sirandreww-starkware sirandreww-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @noamsp-starkware and @ShahakShama)

a discussion (no related file):

Previously, ShahakShama wrote…

Please change the PR title (the title is what matters as it will be the message of the commit once we merge) to something more descriptive

Done.

ShahakShama
ShahakShama approved these changes Dec 7, 2025
View reviewed changes
Copy link
Collaborator

@ShahakShama ShahakShama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @noamsp-starkware)

This was referenced Dec 7, 2025
Open
Open
Open
Open
Open
Open
@sirandreww-starkware sirandreww-starkware added this pull request to the merge queue Dec 7, 2025
Merged via the queue into main with commit f821960 Dec 7, 2025
62 of 67 checks passed
@sirandreww-starkware sirandreww-starkware mentioned this pull request Dec 8, 2025
Open
This was referenced Dec 8, 2025
Open
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ShahakShama ShahakShama ShahakShama approved these changes

@noamsp-starkware noamsp-starkware Awaiting requested review from noamsp-starkware

Assignees

@sirandreww-starkware sirandreww-starkware

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@sirandreww-starkware @reviewable-StarkWare @ShahakShama