apollo_network_benchmark: setup trace logging in benchmark #10607
+43
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
This was referenced Dec 7, 2025
Contributor
Author
This was referenced Dec 7, 2025
sirandreww-starkware
force-pushed
the
12-04-apollo_network_benchmark_moved_args_file
branch
from
c8c4982 to
b606553
Compare
sirandreww-starkware
force-pushed
the
12-07-apollo_network_benchmark_setup_trace_logging_in_benchmark
branch
from
a95a845 to
790ee1a
Compare
ShahakShama
approved these changes
Dec 9, 2025
Collaborator
ShahakShama
left a comment
ShahakShama
left a comment
There was a problem hiding this comment.
@ShahakShama reviewed 1 of 4 files at r1.
Reviewable status: 1 of 4 files reviewed, all discussions resolved (waiting on @noamsp-starkware)
sirandreww-starkware
force-pushed
the
12-07-apollo_network_benchmark_setup_trace_logging_in_benchmark
branch
from
790ee1a to
74b36f1
Compare
sirandreww-starkware
force-pushed
the
12-04-apollo_network_benchmark_moved_args_file
branch
from
b606553 to
bd06e34
Compare
This was referenced Dec 9, 2025
noamsp-starkware
approved these changes
Dec 9, 2025
Contributor
noamsp-starkware
left a comment
noamsp-starkware
left a comment
There was a problem hiding this comment.
@noamsp-starkware reviewed 4 of 4 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @sirandreww-starkware)
graphite-app
bot
changed the base branch from
12-04-apollo_network_benchmark_moved_args_file
to
graphite-base/10607
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.