Skip to content

starknet_api: implement TryFrom from StarknetVersion into Felt #10623

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Yoni-Starkware merged 1 commit into from
Dec 9, 2025
Merged

starknet_api: implement TryFrom from StarknetVersion into Felt #10623

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions crates/starknet_api/src/block.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ use strum_macros::EnumIter;
use time::OffsetDateTime;

use crate::core::{
ascii_as_felt,
ContractAddress,
EventCommitment,
GlobalRoot,
Expand Down Expand Up @@ -166,6 +167,14 @@ impl TryFrom<&str> for StarknetVersion {
}
}

impl TryFrom<&StarknetVersion> for Felt {
type Error = StarknetApiError;

fn try_from(starknet_version: &StarknetVersion) -> Result<Self, Self::Error> {
ascii_as_felt(&starknet_version.to_string())
}
}

impl Serialize for StarknetVersion {
fn serialize<S>(
&self,
Expand Down
2 changes: 1 addition & 1 deletion crates/starknet_api/src/block_hash/block_hash_calculator.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -162,7 +162,7 @@ pub fn calculate_block_hash(
.iter(),
)
.chain(
&ascii_as_felt(&partial_block_hash_components.starknet_version.to_string())
&Felt::try_from(&partial_block_hash_components.starknet_version)
.expect("Expect ASCII version"),
)
.chain(&Felt::ZERO)
Expand Down
3 changes: 1 addition & 2 deletions crates/starknet_os/src/hints/hint_implementation/block_hash/test.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,6 @@ use starknet_api::block_hash::block_hash_calculator::{
STARKNET_BLOCK_HASH1,
};
use starknet_api::core::{
ascii_as_felt,
EventCommitment,
GlobalRoot,
ReceiptCommitment,
Expand Down Expand Up @@ -109,7 +108,7 @@ fn cairo_calculate_block_hash(
EndpointArg::from(gas_prices_hash),
EndpointArg::from(state_root),
EndpointArg::from(parent_hash),
EndpointArg::from(ascii_as_felt(&components.starknet_version.to_string()).unwrap()),
EndpointArg::from(Felt::try_from(&components.starknet_version).unwrap()),
];

// We expect one felt as return value (block_hash).
Expand Down
Loading